luo980/curl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
a3bd1dda12
curl/tests/http/clients
History
Viktor Szakats e512fbfa67
printf: fix mingw-w64 format checks 
Change mingw-w64 printf format checks in public curl headers to use
`__MINGW_PRINTF_FORMAT` instead of `gnu_printf`. This syncs the format
checker with format string macros published via `curl/system.h`. (Also
disable format checks for mingw-w64 older than 3.0.0 (2013-09-20) and
classic-mingw, which do not support this macro.)

This fixes bogus format checker `-Wformat` warnings in 3rd party code
using curl format strings with the curl printf functions, when using
mingw-w64 7.0.0 (2019-11-10) and older (with GCC, MSVCRT).

It also allows to delete two workaounds for this within curl itself:
- setting `-D__USE_MINGW_ANSI_STDIO=1` for mingw-w64 via cmake and
  configure for `docs/examples` and `tests/http/clients`.
  Ref: c730c8549b #14640

The format check macro is incompatible (depending on mingw-w64 version
and configuration) with the C99 `%z` (`size_t`) format string used
internally by curl.

To work around this problem, override the format check style in curl
public headers to use `gnu_printf`. This is compatible with `%z` in all
mingw-w64 versions and allows keeping the C99 format strings internally.

Also:
- lib/ws.c: add missing space to an error message.
- docs/examples/ftpgetinfo.c: fix to use standard printf.

Ref: #14643 (take 1)
Follow-up to 3829759bd0 #12489

Closes #14703
2024-09-02 21:03:01 +02:00
..
.gitignore tidy-up: whitespace [ci skip] 2024-04-05 15:50:07 +00:00
CMakeLists.txt printf: fix mingw-w64 format checks 2024-09-02 21:03:01 +02:00
h2-download.c build: make CURL_FORMAT_CURL_OFF_T[U] work with mingw-w64 <=7.0.0 2024-08-22 10:45:04 +02:00
h2-pausing.c build: make CURL_FORMAT_CURL_OFF_T[U] work with mingw-w64 <=7.0.0 2024-08-22 10:45:04 +02:00
h2-serverpush.c build: make CURL_FORMAT_CURL_OFF_T[U] work with mingw-w64 <=7.0.0 2024-08-22 10:45:04 +02:00
h2-upgrade-extreme.c build: make CURL_FORMAT_CURL_OFF_T[U] work with mingw-w64 <=7.0.0 2024-08-22 10:45:04 +02:00
Makefile.am printf: fix mingw-w64 format checks 2024-09-02 21:03:01 +02:00
Makefile.inc cmake: add Linux CI job, fix pytest with cmake 2024-08-06 02:40:32 +02:00
tls-session-reuse.c build: make CURL_FORMAT_CURL_OFF_T[U] work with mingw-w64 <=7.0.0 2024-08-22 10:45:04 +02:00
upload-pausing.c build: make CURL_FORMAT_CURL_OFF_T[U] work with mingw-w64 <=7.0.0 2024-08-22 10:45:04 +02:00
ws-data.c tidy-up: spelling WebSockets 2024-08-22 17:43:57 +02:00
ws-pingpong.c tidy-up: spelling WebSockets 2024-08-22 17:43:57 +02:00