84338c4de2
Enable more picky compiler warnings. I've found these options in the nghttp3 project when implementing the CMake quick picky warning functionality for it [1]. `-Wunused-macros` was too noisy to keep around, but fixed a few issues it revealed while testing. - autotools: reflect the more precisely-versioned clang warnings. Follow-up to033f8e2a08#12324 - autotools: sync between clang and gcc the way we set `no-multichar`. - autotools: avoid setting `-Wstrict-aliasing=3` twice. - autotools: disable `-Wmissing-noreturn` for MSYS gcc targets [2]. It triggers in libtool-generated stub code. - lib/timeval: delete a redundant `!MSDOS` guard from a `WIN32` branch. - lib/curl_setup.h: delete duplicate declaration for `fileno`. Added in initial commitae1912cb0d(1999-12-29). This suggests this may not be needed anymore, but if it does, we may restore this for those specific (non-Windows) systems. - lib: delete unused macro `FTP_BUFFER_ALLOCSIZE` sincec1d6fe2aaa. - lib: delete unused macro `isxdigit_ascii` sincef65f750742. - lib/mqtt: delete unused macro `MQTT_HEADER_LEN`. - lib/multi: delete unused macro `SH_READ`/`SH_WRITE`. - lib/hostip: add `noreturn` function attribute via new `CURL_NORETURN` macro. - lib/mprintf: delete duplicate declaration for `Curl_dyn_vprintf`. - lib/rand: fix `-Wunreachable-code` and related fallouts [3]. - lib/setopt: fix `-Wunreachable-code-break`. - lib/system_win32 and lib/timeval: fix double declarations for `Curl_freq` and `Curl_isVistaOrGreater` in CMake UNITY mode [4]. - lib/warnless: fix double declarations in CMake UNITY mode [5]. This was due to force-disabling the header guard of `warnless.h` to to reapply it to source code coming after `warnless.c` in UNITY builds. This reapplied declarations too, causing the warnings. Solved by adding a header guard for the lines that actually need to be reapplied. - lib/vauth/digest: fix `-Wunreachable-code-break` [6]. - lib/vssh/libssh2: fix `-Wunreachable-code-break` and delete redundant block. - lib/vtls/sectransp: fix `-Wunreachable-code-break` [7]. - lib/vtls/sectransp: suppress `-Wunreachable-code`. Detected in `else` branches of dynamic feature checks, with results known at compile-time, e.g. ```c if(SecCertificateCopySubjectSummary) /* -> true */ ``` Likely fixable as a separate micro-project, but given SecureTransport is deprecated anyway, let's just silence these locally. - src/tool_help: delete duplicate declaration for `helptext`. - src/tool_xattr: fix `-Wunreachable-code`. - tests: delete duplicate declaration for `unitfail` [8]. - tests: delete duplicate declaration for `strncasecompare`. - tests/libtest: delete duplicate declaration for `gethostname`. Originally added in687df5c8c3(2010-08-02). Got complicated later:c49e9683b8If there are still systems around with warnings, we may restore the prototype, but limited for those systems. - tests/lib2305: delete duplicate declaration for `libtest_debug_config`. - tests/h2-download: fix `-Wunreachable-code-break`. [1]a70edb08e9/cmake/PickyWarningsC.cmake[2] https://ci.appveyor.com/project/curlorg/curl/builds/48553586/job/3qkgjauiqla5fj45?fullLog=true#L1675 [3] https://github.com/curl/curl/actions/runs/6880886309/job/18716044703?pr=12331#step:7:72 https://github.com/curl/curl/actions/runs/6883016087/job/18722707368?pr=12331#step:7:109 [4] https://ci.appveyor.com/project/curlorg/curl/builds/48555101/job/9g15qkrriklpf1ut#L204 [5] https://ci.appveyor.com/project/curlorg/curl/builds/48555101/job/9g15qkrriklpf1ut#L218 [6] https://github.com/curl/curl/actions/runs/6880886309/job/18716042927?pr=12331#step:7:290 [7] https://github.com/curl/curl/actions/runs/6891484996/job/18746659406?pr=12331#step:9:1193 [8] https://github.com/curl/curl/actions/runs/6882803986/job/18722082562?pr=12331#step:33:1870 Closes #12331
387 lines
8.2 KiB
C
387 lines
8.2 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
|
|
#include "curl_setup.h"
|
|
|
|
#if defined(__INTEL_COMPILER) && defined(__unix__)
|
|
|
|
#ifdef HAVE_NETINET_IN_H
|
|
# include <netinet/in.h>
|
|
#endif
|
|
#ifdef HAVE_ARPA_INET_H
|
|
# include <arpa/inet.h>
|
|
#endif
|
|
|
|
#endif /* __INTEL_COMPILER && __unix__ */
|
|
|
|
#include "warnless.h"
|
|
|
|
#ifdef WIN32
|
|
#undef read
|
|
#undef write
|
|
#endif
|
|
|
|
#include <limits.h>
|
|
|
|
#define CURL_MASK_UCHAR ((unsigned char)~0)
|
|
#define CURL_MASK_SCHAR (CURL_MASK_UCHAR >> 1)
|
|
|
|
#define CURL_MASK_USHORT ((unsigned short)~0)
|
|
#define CURL_MASK_SSHORT (CURL_MASK_USHORT >> 1)
|
|
|
|
#define CURL_MASK_UINT ((unsigned int)~0)
|
|
#define CURL_MASK_SINT (CURL_MASK_UINT >> 1)
|
|
|
|
#define CURL_MASK_ULONG ((unsigned long)~0)
|
|
#define CURL_MASK_SLONG (CURL_MASK_ULONG >> 1)
|
|
|
|
#define CURL_MASK_UCOFFT ((unsigned CURL_TYPEOF_CURL_OFF_T)~0)
|
|
#define CURL_MASK_SCOFFT (CURL_MASK_UCOFFT >> 1)
|
|
|
|
#define CURL_MASK_USIZE_T ((size_t)~0)
|
|
#define CURL_MASK_SSIZE_T (CURL_MASK_USIZE_T >> 1)
|
|
|
|
/*
|
|
** unsigned long to unsigned short
|
|
*/
|
|
|
|
unsigned short curlx_ultous(unsigned long ulnum)
|
|
{
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(push)
|
|
# pragma warning(disable:810) /* conversion may lose significant bits */
|
|
#endif
|
|
|
|
DEBUGASSERT(ulnum <= (unsigned long) CURL_MASK_USHORT);
|
|
return (unsigned short)(ulnum & (unsigned long) CURL_MASK_USHORT);
|
|
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(pop)
|
|
#endif
|
|
}
|
|
|
|
/*
|
|
** unsigned long to unsigned char
|
|
*/
|
|
|
|
unsigned char curlx_ultouc(unsigned long ulnum)
|
|
{
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(push)
|
|
# pragma warning(disable:810) /* conversion may lose significant bits */
|
|
#endif
|
|
|
|
DEBUGASSERT(ulnum <= (unsigned long) CURL_MASK_UCHAR);
|
|
return (unsigned char)(ulnum & (unsigned long) CURL_MASK_UCHAR);
|
|
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(pop)
|
|
#endif
|
|
}
|
|
|
|
/*
|
|
** unsigned size_t to signed curl_off_t
|
|
*/
|
|
|
|
curl_off_t curlx_uztoso(size_t uznum)
|
|
{
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(push)
|
|
# pragma warning(disable:810) /* conversion may lose significant bits */
|
|
#elif defined(_MSC_VER)
|
|
# pragma warning(push)
|
|
# pragma warning(disable:4310) /* cast truncates constant value */
|
|
#endif
|
|
|
|
DEBUGASSERT(uznum <= (size_t) CURL_MASK_SCOFFT);
|
|
return (curl_off_t)(uznum & (size_t) CURL_MASK_SCOFFT);
|
|
|
|
#if defined(__INTEL_COMPILER) || defined(_MSC_VER)
|
|
# pragma warning(pop)
|
|
#endif
|
|
}
|
|
|
|
/*
|
|
** unsigned size_t to signed int
|
|
*/
|
|
|
|
int curlx_uztosi(size_t uznum)
|
|
{
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(push)
|
|
# pragma warning(disable:810) /* conversion may lose significant bits */
|
|
#endif
|
|
|
|
DEBUGASSERT(uznum <= (size_t) CURL_MASK_SINT);
|
|
return (int)(uznum & (size_t) CURL_MASK_SINT);
|
|
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(pop)
|
|
#endif
|
|
}
|
|
|
|
/*
|
|
** unsigned size_t to unsigned long
|
|
*/
|
|
|
|
unsigned long curlx_uztoul(size_t uznum)
|
|
{
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(push)
|
|
# pragma warning(disable:810) /* conversion may lose significant bits */
|
|
#endif
|
|
|
|
#if ULONG_MAX < SIZE_T_MAX
|
|
DEBUGASSERT(uznum <= (size_t) CURL_MASK_ULONG);
|
|
#endif
|
|
return (unsigned long)(uznum & (size_t) CURL_MASK_ULONG);
|
|
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(pop)
|
|
#endif
|
|
}
|
|
|
|
/*
|
|
** unsigned size_t to unsigned int
|
|
*/
|
|
|
|
unsigned int curlx_uztoui(size_t uznum)
|
|
{
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(push)
|
|
# pragma warning(disable:810) /* conversion may lose significant bits */
|
|
#endif
|
|
|
|
#if UINT_MAX < SIZE_T_MAX
|
|
DEBUGASSERT(uznum <= (size_t) CURL_MASK_UINT);
|
|
#endif
|
|
return (unsigned int)(uznum & (size_t) CURL_MASK_UINT);
|
|
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(pop)
|
|
#endif
|
|
}
|
|
|
|
/*
|
|
** signed long to signed int
|
|
*/
|
|
|
|
int curlx_sltosi(long slnum)
|
|
{
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(push)
|
|
# pragma warning(disable:810) /* conversion may lose significant bits */
|
|
#endif
|
|
|
|
DEBUGASSERT(slnum >= 0);
|
|
#if INT_MAX < LONG_MAX
|
|
DEBUGASSERT((unsigned long) slnum <= (unsigned long) CURL_MASK_SINT);
|
|
#endif
|
|
return (int)(slnum & (long) CURL_MASK_SINT);
|
|
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(pop)
|
|
#endif
|
|
}
|
|
|
|
/*
|
|
** signed long to unsigned int
|
|
*/
|
|
|
|
unsigned int curlx_sltoui(long slnum)
|
|
{
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(push)
|
|
# pragma warning(disable:810) /* conversion may lose significant bits */
|
|
#endif
|
|
|
|
DEBUGASSERT(slnum >= 0);
|
|
#if UINT_MAX < LONG_MAX
|
|
DEBUGASSERT((unsigned long) slnum <= (unsigned long) CURL_MASK_UINT);
|
|
#endif
|
|
return (unsigned int)(slnum & (long) CURL_MASK_UINT);
|
|
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(pop)
|
|
#endif
|
|
}
|
|
|
|
/*
|
|
** signed long to unsigned short
|
|
*/
|
|
|
|
unsigned short curlx_sltous(long slnum)
|
|
{
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(push)
|
|
# pragma warning(disable:810) /* conversion may lose significant bits */
|
|
#endif
|
|
|
|
DEBUGASSERT(slnum >= 0);
|
|
DEBUGASSERT((unsigned long) slnum <= (unsigned long) CURL_MASK_USHORT);
|
|
return (unsigned short)(slnum & (long) CURL_MASK_USHORT);
|
|
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(pop)
|
|
#endif
|
|
}
|
|
|
|
/*
|
|
** unsigned size_t to signed ssize_t
|
|
*/
|
|
|
|
ssize_t curlx_uztosz(size_t uznum)
|
|
{
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(push)
|
|
# pragma warning(disable:810) /* conversion may lose significant bits */
|
|
#endif
|
|
|
|
DEBUGASSERT(uznum <= (size_t) CURL_MASK_SSIZE_T);
|
|
return (ssize_t)(uznum & (size_t) CURL_MASK_SSIZE_T);
|
|
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(pop)
|
|
#endif
|
|
}
|
|
|
|
/*
|
|
** signed curl_off_t to unsigned size_t
|
|
*/
|
|
|
|
size_t curlx_sotouz(curl_off_t sonum)
|
|
{
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(push)
|
|
# pragma warning(disable:810) /* conversion may lose significant bits */
|
|
#endif
|
|
|
|
DEBUGASSERT(sonum >= 0);
|
|
return (size_t)(sonum & (curl_off_t) CURL_MASK_USIZE_T);
|
|
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(pop)
|
|
#endif
|
|
}
|
|
|
|
/*
|
|
** signed ssize_t to signed int
|
|
*/
|
|
|
|
int curlx_sztosi(ssize_t sznum)
|
|
{
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(push)
|
|
# pragma warning(disable:810) /* conversion may lose significant bits */
|
|
#endif
|
|
|
|
DEBUGASSERT(sznum >= 0);
|
|
#if INT_MAX < SSIZE_T_MAX
|
|
DEBUGASSERT((size_t) sznum <= (size_t) CURL_MASK_SINT);
|
|
#endif
|
|
return (int)(sznum & (ssize_t) CURL_MASK_SINT);
|
|
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(pop)
|
|
#endif
|
|
}
|
|
|
|
/*
|
|
** unsigned int to unsigned short
|
|
*/
|
|
|
|
unsigned short curlx_uitous(unsigned int uinum)
|
|
{
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(push)
|
|
# pragma warning(disable:810) /* conversion may lose significant bits */
|
|
#endif
|
|
|
|
DEBUGASSERT(uinum <= (unsigned int) CURL_MASK_USHORT);
|
|
return (unsigned short) (uinum & (unsigned int) CURL_MASK_USHORT);
|
|
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(pop)
|
|
#endif
|
|
}
|
|
|
|
/*
|
|
** signed int to unsigned size_t
|
|
*/
|
|
|
|
size_t curlx_sitouz(int sinum)
|
|
{
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(push)
|
|
# pragma warning(disable:810) /* conversion may lose significant bits */
|
|
#endif
|
|
|
|
DEBUGASSERT(sinum >= 0);
|
|
return (size_t) sinum;
|
|
|
|
#ifdef __INTEL_COMPILER
|
|
# pragma warning(pop)
|
|
#endif
|
|
}
|
|
|
|
#ifdef USE_WINSOCK
|
|
|
|
/*
|
|
** curl_socket_t to signed int
|
|
*/
|
|
|
|
int curlx_sktosi(curl_socket_t s)
|
|
{
|
|
return (int)((ssize_t) s);
|
|
}
|
|
|
|
/*
|
|
** signed int to curl_socket_t
|
|
*/
|
|
|
|
curl_socket_t curlx_sitosk(int i)
|
|
{
|
|
return (curl_socket_t)((ssize_t) i);
|
|
}
|
|
|
|
#endif /* USE_WINSOCK */
|
|
|
|
#if defined(WIN32)
|
|
|
|
ssize_t curlx_read(int fd, void *buf, size_t count)
|
|
{
|
|
return (ssize_t)read(fd, buf, curlx_uztoui(count));
|
|
}
|
|
|
|
ssize_t curlx_write(int fd, const void *buf, size_t count)
|
|
{
|
|
return (ssize_t)write(fd, buf, curlx_uztoui(count));
|
|
}
|
|
|
|
#endif /* WIN32 */
|
|
|
|
/* Ensure that warnless.h redefinitions continue to have an effect
|
|
in "unity" builds. */
|
|
#undef HEADER_CURL_WARNLESS_H_REDEFS
|