curl/tests/unit
Stefan Eissing 47f5b1a37f
lib: introduce struct easy_poll_set for poll information
Connection filter had a `get_select_socks()` method, inspired by the
various `getsocks` functions involved during the lifetime of a
transfer. These, depending on transfer state (CONNECT/DO/DONE/ etc.),
return sockets to monitor and flag if this shall be done for POLLIN
and/or POLLOUT.

Due to this design, sockets and flags could only be added, not
removed. This led to problems in filters like HTTP/2 where flow control
prohibits the sending of data until the peer increases the flow
window. The general transfer loop wants to write, adds POLLOUT, the
socket is writeable but no data can be written.

This leads to cpu busy loops. To prevent that, HTTP/2 did set the
`SEND_HOLD` flag of such a blocked transfer, so the transfer loop cedes
further attempts. This works if only one such filter is involved. If a
HTTP/2 transfer goes through a HTTP/2 proxy, two filters are
setting/clearing this flag and may step on each other's toes.

Connection filters `get_select_socks()` is replaced by
`adjust_pollset()`. They get passed a `struct easy_pollset` that keeps
up to `MAX_SOCKSPEREASYHANDLE` sockets and their `POLLIN|POLLOUT`
flags. This struct is initialized in `multi_getsock()` by calling the
various `getsocks()` implementations based on transfer state, as before.

After protocol handlers/transfer loop have set the sockets and flags
they want, the `easy_pollset` is *always* passed to the filters. Filters
"higher" in the chain are called first, starting at the first
not-yet-connection one. Each filter may add sockets and/or change
flags. When all flags are removed, the socket itself is removed from the
pollset.

Example:

 * transfer wants to send, adds POLLOUT
 * http/2 filter has a flow control block, removes POLLOUT and adds
   POLLIN (it is waiting on a WINDOW_UPDATE from the server)
 * TLS filter is connected and changes nothing
 * h2-proxy filter also has a flow control block on its tunnel stream,
   removes POLLOUT and adds POLLIN also.
 * socket filter is connected and changes nothing
 * The resulting pollset is then mixed together with all other transfers
   and their pollsets, just as before.

Use of `SEND_HOLD` is no longer necessary in the filters.

All filters are adapted for the changed method. The handling in
`multi.c` has been adjusted, but its state handling the the protocol
handlers' `getsocks` method are untouched.

The most affected filters are http/2, ngtcp2, quiche and h2-proxy. TLS
filters needed to be adjusted for the connecting handshake read/write
handling.

No noticeable difference in performance was detected in local scorecard
runs.

Closes #11833
2023-10-25 09:34:32 +02:00
..
.gitignore copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
CMakeLists.txt cmake: add libcurlu/libcurltool for unit tests 2023-07-21 12:04:45 +02:00
curlcheck.h tests: log the test result code after each libtest 2023-09-16 08:33:45 -07:00
Makefile.am nss: remove support for this TLS library 2023-07-29 23:44:28 +02:00
Makefile.inc unittest/makefile: remove unneeded unit1621_LDADD 2023-07-21 12:08:12 +02:00
README.md tests: fix unit tests to run with a dynamic log directory 2023-03-30 09:53:57 -07:00
unit1300.c spelling: fix codespell 2.2.6 typos 2023-10-03 21:37:56 +00:00
unit1302.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1303.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1304.c test1304: build and skip without netrc support 2023-08-17 17:17:59 +02:00
unit1305.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1307.c tests: fix MSVC unreachable code warnings in unit tests 2023-03-11 18:54:21 -08:00
unit1308.c misc: better random strings 2023-09-16 11:37:57 +02:00
unit1309.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1323.c tests: fix bad printf format flags in test code 2023-08-07 10:46:14 +02:00
unit1330.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1394.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1395.c urlapi: cleanups 2023-04-13 08:41:40 +02:00
unit1396.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1397.c gskit: remove 2023-08-07 20:57:48 +02:00
unit1398.c tests: fix bad printf format flags in test code 2023-08-07 10:46:14 +02:00
unit1399.c misc: fix spelling mistakes 2023-05-23 10:42:09 +02:00
unit1600.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1601.c lib: add ability to disable auths individually 2023-09-07 17:45:06 +02:00
unit1602.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1603.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1604.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1605.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1606.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1607.c tests: fix bad printf format flags in test code 2023-08-07 10:46:14 +02:00
unit1608.c test1608: make it build and get skipped without shuffle DNS support 2023-08-17 17:17:59 +02:00
unit1609.c tests: fix bad printf format flags in test code 2023-08-07 10:46:14 +02:00
unit1610.c lib: add ability to disable auths individually 2023-09-07 17:45:06 +02:00
unit1611.c md4: only build when used 2023-05-13 09:57:35 +02:00
unit1612.c lib: add ability to disable auths individually 2023-09-07 17:45:06 +02:00
unit1614.c tests: fix MSVC unreachable code warnings in unit tests 2023-03-11 18:54:21 -08:00
unit1620.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1621.c unit tests: use the unit test infrastructure better 2023-04-01 08:59:38 -07:00
unit1650.c unit tests: use the unit test infrastructure better 2023-04-01 08:59:38 -07:00
unit1651.c gskit: remove 2023-08-07 20:57:48 +02:00
unit1652.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1653.c checksrc: disallow spaces before labels 2023-05-18 20:45:04 +02:00
unit1654.c checksrc: disallow spaces before labels 2023-05-18 20:45:04 +02:00
unit1655.c unit tests: use the unit test infrastructure better 2023-04-01 08:59:38 -07:00
unit1660.c unit tests: use the unit test infrastructure better 2023-04-01 08:59:38 -07:00
unit1661.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit2600.c lib: introduce struct easy_poll_set for poll information 2023-10-25 09:34:32 +02:00
unit2601.c trace: make tracing available in non-debug builds 2023-08-03 17:32:25 +02:00
unit2602.c trace: make tracing available in non-debug builds 2023-08-03 17:32:25 +02:00
unit2603.c trace: make tracing available in non-debug builds 2023-08-03 17:32:25 +02:00
unit3200.c unit3200: skip testing if function is not present 2023-08-17 17:17:59 +02:00

Unit tests

The goal is to add tests for all functions in libcurl. If functions are too big and complicated, we should split them into smaller and testable ones.

Build Unit Tests

./configure --enable-debug is required for the unit tests to build. To enable unit tests, there will be a separate static libcurl built that will be used exclusively for linking unit test programs. Just build everything as normal, and then you can run the unit test cases as well.

Run Unit Tests

Unit tests are run as part of the regular test suite. If you have built everything to run unit tests, to can do 'make test' at the root level. Or you can cd tests and make and then invoke individual unit tests with ./runtests.pl NNNN where NNNN is the specific test number.

Debug Unit Tests

If a specific test fails you will get told. The test case then has output left in the %LOGDIR subdirectory, but most importantly you can re-run the test again using gdb by doing ./runtests.pl -g NNNN. That is, add a -g to make it start up gdb and run the same case using that.

Write Unit Tests

We put tests that focus on an area or a specific function into a single C source file. The source file should be named unitNNNN.c where NNNN is a previously unused number.

Add your test to tests/unit/Makefile.inc (if it is a unit test). Add your test data file name to tests/data/Makefile.inc

You also need a separate file called tests/data/testNNNN (using the same number) that describes your test case. See the test1300 file for inspiration and the tests/FILEFORMAT.md documentation.

For the actual C file, here's a simple example:


    #include "curlcheck.h"

    #include "a libcurl header.h" /* from the lib dir */

    static CURLcode unit_setup( void )
    {
      /* whatever you want done first */
      return CURLE_OK;
    }

    static void unit_stop( void )
    {
      /* done before shutting down and exiting */
    }

    UNITTEST_START

      /* here you start doing things and checking that the results are good */

      fail_unless( size == 0 , "initial size should be zero" );
      fail_if( head == NULL , "head should not be initiated to NULL" );

      /* you end the test code like this: */

    UNITTEST_STOP