curl/tests/unit
Viktor Szakats 84338c4de2
build: add more picky warnings and fix them
Enable more picky compiler warnings. I've found these options in the
nghttp3 project when implementing the CMake quick picky warning
functionality for it [1].

`-Wunused-macros` was too noisy to keep around, but fixed a few issues
it revealed while testing.

- autotools: reflect the more precisely-versioned clang warnings.
  Follow-up to 033f8e2a08 #12324
- autotools: sync between clang and gcc the way we set `no-multichar`.
- autotools: avoid setting `-Wstrict-aliasing=3` twice.
- autotools: disable `-Wmissing-noreturn` for MSYS gcc targets [2].
  It triggers in libtool-generated stub code.

- lib/timeval: delete a redundant `!MSDOS` guard from a `WIN32` branch.

- lib/curl_setup.h: delete duplicate declaration for `fileno`.
  Added in initial commit ae1912cb0d
  (1999-12-29). This suggests this may not be needed anymore, but if
  it does, we may restore this for those specific (non-Windows) systems.
- lib: delete unused macro `FTP_BUFFER_ALLOCSIZE` since
  c1d6fe2aaa.
- lib: delete unused macro `isxdigit_ascii` since
  f65f750742.
- lib/mqtt: delete unused macro `MQTT_HEADER_LEN`.
- lib/multi: delete unused macro `SH_READ`/`SH_WRITE`.
- lib/hostip: add `noreturn` function attribute via new `CURL_NORETURN`
  macro.
- lib/mprintf: delete duplicate declaration for `Curl_dyn_vprintf`.
- lib/rand: fix `-Wunreachable-code` and related fallouts [3].
- lib/setopt: fix `-Wunreachable-code-break`.
- lib/system_win32 and lib/timeval: fix double declarations for
  `Curl_freq` and `Curl_isVistaOrGreater` in CMake UNITY mode [4].
- lib/warnless: fix double declarations in CMake UNITY mode [5].
  This was due to force-disabling the header guard of `warnless.h` to
  to reapply it to source code coming after `warnless.c` in UNITY
  builds. This reapplied declarations too, causing the warnings.
  Solved by adding a header guard for the lines that actually need
  to be reapplied.
- lib/vauth/digest: fix `-Wunreachable-code-break` [6].
- lib/vssh/libssh2: fix `-Wunreachable-code-break` and delete redundant
  block.
- lib/vtls/sectransp: fix `-Wunreachable-code-break` [7].
- lib/vtls/sectransp: suppress `-Wunreachable-code`.
  Detected in `else` branches of dynamic feature checks, with results
  known at compile-time, e.g.
  ```c
  if(SecCertificateCopySubjectSummary)  /* -> true */
  ```
  Likely fixable as a separate micro-project, but given SecureTransport
  is deprecated anyway, let's just silence these locally.
- src/tool_help: delete duplicate declaration for `helptext`.
- src/tool_xattr: fix `-Wunreachable-code`.
- tests: delete duplicate declaration for `unitfail` [8].
- tests: delete duplicate declaration for `strncasecompare`.
- tests/libtest: delete duplicate declaration for `gethostname`.
  Originally added in 687df5c8c3
  (2010-08-02).
  Got complicated later: c49e9683b8
  If there are still systems around with warnings, we may restore the
  prototype, but limited for those systems.
- tests/lib2305: delete duplicate declaration for
  `libtest_debug_config`.
- tests/h2-download: fix `-Wunreachable-code-break`.

[1] a70edb08e9/cmake/PickyWarningsC.cmake
[2] https://ci.appveyor.com/project/curlorg/curl/builds/48553586/job/3qkgjauiqla5fj45?fullLog=true#L1675
[3] https://github.com/curl/curl/actions/runs/6880886309/job/18716044703?pr=12331#step:7:72
    https://github.com/curl/curl/actions/runs/6883016087/job/18722707368?pr=12331#step:7:109
[4] https://ci.appveyor.com/project/curlorg/curl/builds/48555101/job/9g15qkrriklpf1ut#L204
[5] https://ci.appveyor.com/project/curlorg/curl/builds/48555101/job/9g15qkrriklpf1ut#L218
[6] https://github.com/curl/curl/actions/runs/6880886309/job/18716042927?pr=12331#step:7:290
[7] https://github.com/curl/curl/actions/runs/6891484996/job/18746659406?pr=12331#step:9:1193
[8] https://github.com/curl/curl/actions/runs/6882803986/job/18722082562?pr=12331#step:33:1870

Closes #12331
2023-11-21 16:35:42 +00:00
..
.gitignore copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
CMakeLists.txt cmake: add libcurlu/libcurltool for unit tests 2023-07-21 12:04:45 +02:00
curlcheck.h build: add more picky warnings and fix them 2023-11-21 16:35:42 +00:00
Makefile.am nss: remove support for this TLS library 2023-07-29 23:44:28 +02:00
Makefile.inc unittest/makefile: remove unneeded unit1621_LDADD 2023-07-21 12:08:12 +02:00
README.md tests: fix unit tests to run with a dynamic log directory 2023-03-30 09:53:57 -07:00
unit1300.c spelling: fix codespell 2.2.6 typos 2023-10-03 21:37:56 +00:00
unit1302.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1303.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1304.c test1304: build and skip without netrc support 2023-08-17 17:17:59 +02:00
unit1305.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1307.c tests: fix MSVC unreachable code warnings in unit tests 2023-03-11 18:54:21 -08:00
unit1308.c misc: better random strings 2023-09-16 11:37:57 +02:00
unit1309.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1323.c tests: fix bad printf format flags in test code 2023-08-07 10:46:14 +02:00
unit1330.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1394.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1395.c autotools: stop setting -std=gnu89 with --enable-warnings 2023-11-20 22:28:17 +00:00
unit1396.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1397.c gskit: remove 2023-08-07 20:57:48 +02:00
unit1398.c tests: fix bad printf format flags in test code 2023-08-07 10:46:14 +02:00
unit1399.c misc: fix spelling mistakes 2023-05-23 10:42:09 +02:00
unit1600.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1601.c lib: add ability to disable auths individually 2023-09-07 17:45:06 +02:00
unit1602.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1603.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1604.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1605.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1606.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1607.c tests: fix bad printf format flags in test code 2023-08-07 10:46:14 +02:00
unit1608.c test1608: make it build and get skipped without shuffle DNS support 2023-08-17 17:17:59 +02:00
unit1609.c tests: fix bad printf format flags in test code 2023-08-07 10:46:14 +02:00
unit1610.c lib: add ability to disable auths individually 2023-09-07 17:45:06 +02:00
unit1611.c md4: only build when used 2023-05-13 09:57:35 +02:00
unit1612.c lib: add ability to disable auths individually 2023-09-07 17:45:06 +02:00
unit1614.c tests: fix MSVC unreachable code warnings in unit tests 2023-03-11 18:54:21 -08:00
unit1620.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1621.c unit tests: use the unit test infrastructure better 2023-04-01 08:59:38 -07:00
unit1650.c unit tests: use the unit test infrastructure better 2023-04-01 08:59:38 -07:00
unit1651.c gskit: remove 2023-08-07 20:57:48 +02:00
unit1652.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit1653.c checksrc: disallow spaces before labels 2023-05-18 20:45:04 +02:00
unit1654.c checksrc: disallow spaces before labels 2023-05-18 20:45:04 +02:00
unit1655.c unit tests: use the unit test infrastructure better 2023-04-01 08:59:38 -07:00
unit1660.c unit tests: use the unit test infrastructure better 2023-04-01 08:59:38 -07:00
unit1661.c copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
unit2600.c misc: fix -Walloc-size warnings 2023-11-11 23:35:47 +01:00
unit2601.c trace: make tracing available in non-debug builds 2023-08-03 17:32:25 +02:00
unit2602.c trace: make tracing available in non-debug builds 2023-08-03 17:32:25 +02:00
unit2603.c trace: make tracing available in non-debug builds 2023-08-03 17:32:25 +02:00
unit3200.c build: always revert #pragma GCC diagnostic after use 2023-11-18 11:16:32 +00:00

Unit tests

The goal is to add tests for all functions in libcurl. If functions are too big and complicated, we should split them into smaller and testable ones.

Build Unit Tests

./configure --enable-debug is required for the unit tests to build. To enable unit tests, there will be a separate static libcurl built that will be used exclusively for linking unit test programs. Just build everything as normal, and then you can run the unit test cases as well.

Run Unit Tests

Unit tests are run as part of the regular test suite. If you have built everything to run unit tests, to can do 'make test' at the root level. Or you can cd tests and make and then invoke individual unit tests with ./runtests.pl NNNN where NNNN is the specific test number.

Debug Unit Tests

If a specific test fails you will get told. The test case then has output left in the %LOGDIR subdirectory, but most importantly you can re-run the test again using gdb by doing ./runtests.pl -g NNNN. That is, add a -g to make it start up gdb and run the same case using that.

Write Unit Tests

We put tests that focus on an area or a specific function into a single C source file. The source file should be named unitNNNN.c where NNNN is a previously unused number.

Add your test to tests/unit/Makefile.inc (if it is a unit test). Add your test data file name to tests/data/Makefile.inc

You also need a separate file called tests/data/testNNNN (using the same number) that describes your test case. See the test1300 file for inspiration and the tests/FILEFORMAT.md documentation.

For the actual C file, here's a simple example:


    #include "curlcheck.h"

    #include "a libcurl header.h" /* from the lib dir */

    static CURLcode unit_setup( void )
    {
      /* whatever you want done first */
      return CURLE_OK;
    }

    static void unit_stop( void )
    {
      /* done before shutting down and exiting */
    }

    UNITTEST_START

      /* here you start doing things and checking that the results are good */

      fail_unless( size == 0 , "initial size should be zero" );
      fail_if( head == NULL , "head should not be initiated to NULL" );

      /* you end the test code like this: */

    UNITTEST_STOP