TL;DR: Save 10 minutes of CI time for GHA/macos jobs using pre-fills and
add pre-fill verification for Apple and Windows. Also restores Xcode job
and saves 1.5-10 minutes configuring iOS jobs.
Pre-filling feature detection results can bring down the CMake configure
step to ~5 seconds on most GHA runners, ~10 seconds in slow envs like
Cygwin/MSYS2.
The potential savings per job are:
- 5-40 (average 19) seconds on GHA/macos (33 jobs)
- ~10 seconds on GHA for iOS GNU Makefile (1 job)
- 1.5-10 minutes on GHA for iOS Xcode generator (1 job)
- 10 seconds on GHA/linux with native Ubuntu (12 jobs)
- 40 seconds for Cygwin/MSYS2 (2 jobs)
- 5-10 seconds for virtualized BSDs, native CPU (3 jobs)
- ~60 seconds for virtualized BSDs, emulated CPU (1 job)
On native Windows pre-filling has been in place for a long time and
saving 8 minutes (VS2019-VS2015) to 1.5-2 minutes (VS2022), 3 minutes
(VS2022 UWP), and 30-60 seconds (MinGW), per CI job.
The downside is that detection results need to be manually collected and
filtered to those that universally apply to all platforms that they are
enabled on. Another downside is that by using a cache, we're not running
the actual detections, and thus won't catch regressions in them. It
means we must make sure that the cache is solid and matches with actual
detections results. An upside is that it gives a rough overview of which
features are available on which platforms. Another upside is pre-filled
values do work for feature detections skipped for cross-builds, e.g.
`HAVE_WRITABLE_ARGV`.
This PR adds a pre-fill cache that supports all Unixes (except OmniOS)
used in CI, and makes it usable with an internal option. It also enables
it for GHA/macos CI jobs, where the maximum savings are. And also for
the two iOS [1] and two Cygwin/MSYS2 jobs. The latters don't have
pre-fill checks and we can drop them if they turn into a hassle.
Saving:
- 10 minutes of CI time per GHA/macos workflow run. [2]
- ~80 seconds per GHA/windows workflow run with Cygwin/MSYS2.
(offsetting the cost of pre-fill verifications)
- 1.5-10 minutes per GHA/non-native runs with iOS jobs. [3]
You can enable pre-fill locally with `-D_CURL_PREFILL=ON`. It's
experimental, and if you experience a problem, file a PR or an Issue.
This PR also adds a pre-fill checker for macOS and MinGW/MSVC Windows
GHA jobs to catch if the cache diverges from real detections. It also
adds this logic to AppVeyor, but doesn't enable it due to the perf
penalty of 2 minutes mininum.
The pre-fill checker works by configuring out-of-tree with and without
pre-fill, then diffing their `lib/curl_config.h` outputs.
Exceptions are 3 detection results exposed indirectly [4], and missing
to expose 2, of which one is the C89 header `stddef.h`. While we assume
the C99 `stdint.h` available outside iOS. We can expose them in the
future, if necessary.
The pre-fill checks cost in total:
- ~20 seconds for macOS
- ~40 seconds for MinGW on GHA
- ~80 seconds for MSVC on GHA (UWP would be 2x this)
An extra time saving potential is caching type sizes. They are
well-known, and seldom change, esp. in CI. GHA/Windows jobs spend 8-17
seconds per job on these ~12 feature checks. ~5s on Cygwin/MSYS2. Couple
of seconds on other platforms. (This PR doesn't make this optimization.)
Another opportunity is doing the same for autotools, which typically
spends more time in the configuration step than cmake.
[1] Xcode job restored as a
follow-up to be5f20202c #16302
[2] GHA/macos cmake configure times in seconds:
Job | Bef. | After | Gain
:----------------------------------------------- | ----: | ----: | ----:
CM clang GnuTLS !ldap krb5 | 21.2 | 4.5 | 16.7
CM clang LibreSSL !ldap heimdal c-ares +examples | 13.3 | 3.9 | 9.4
CM clang OpenSSL +static libssh +examples | 20.0 | 4.6 | 15.4
CM clang OpenSSL IDN clang-tidy~ (w/chkprefill) | 15.7 | 18.6 | -2.9
CM clang OpenSSL gsasl rtmp AppleIDN | 25.0 | 4.7 | 20.3
CM clang OpenSSL torture !FTP | 15.3 | 4.5 | 10.8
CM clang OpenSSL torture FTP | 25.0 | 5.9 | 19.1
CM clang SecureTransport debug | 18.0 | 3.8 | 14.2
CM clang macos-13 SecureTransport | 45.8 | 12.4 | 33.4
CM clang macos-14 SecureTransport | 15.8 | 4.6 | 11.2
CM clang macos-15 SecureTransport | 26.8 | 6.1 | 20.7
CM clang mbedTLS openldap brotli zstd | 15.1 | 6.5 | 8.6
CM clang wolfSSL !ldap brotli zstd | 27.0 | 4.4 | 22.6
CM gcc-12 GnuTLS !ldap krb5 | 39.1 | 8.7 | 30.4
CM gcc-12 LibreSSL !ldap heimdal c-ares +examples| 23.8 | 7.2 | 16.6
CM gcc-12 OpenSSL +static libssh +examples | 20.7 | 8.5 | 12.2
CM gcc-12 OpenSSL gsasl rtmp AppleIDN | 23.1 | 10.1 | 13.0
CM gcc-12 SecureTransport debug | 21.1 | 4.8 | 16.3
CM gcc-12 mbedTLS openldap brotli zstd | 21.4 | 5.8 | 15.6
CM gcc-12 wolfSSL !ldap brotli zstd | 21.1 | 6.9 | 14.2
CM gcc-14 macos-13 SecureTransport | 61.9 | 18.7 | 43.2
CM gcc-14 macos-14 SecureTransport | 30.5 | 6.4 | 24.1
CM gcc-14 macos-15 SecureTransport | 32.7 | 8.4 | 24.3
CM llvm@15 GnuTLS !ldap krb5 | 21.1 | 7.5 | 13.6
CM llvm@15 LibreSSL !ldap heimdal c-ares +exampl~| 24.6 | 6.8 | 17.8
CM llvm@15 OpenSSL +static libssh +examples | 19.0 | 6.4 | 12.6
CM llvm@15 OpenSSL gsasl rtmp AppleIDN | 19.0 | 8.2 | 10.8
CM llvm@15 SecureTransport debug | 18.0 | 5.4 | 12.6
CM llvm@15 macos-13 SecureTransport | 66.2 | 25.7 | 40.5
CM llvm@15 macos-14 SecureTransport | 31.9 | 6.1 | 25.8
CM llvm@15 mbedTLS openldap brotli zstd | 19.5 | 8.9 | 10.6
CM llvm@15 wolfSSL !ldap brotli zstd | 24.3 | 5.9 | 18.4
CM llvm@18 macos-15 SecureTransport | 33.8 | 6.4 | 27.4
Total | 856.8 | 257.3 | 599.5
Before: https://github.com/curl/curl/actions/runs/13311042735/job/37173478424
After: https://github.com/curl/curl/actions/runs/13313927119/job/37183206426?pr=15841
[3] iOS:
Before: https://github.com/curl/curl/actions/runs/13326401704?pr=15841
After: https://github.com/curl/curl/actions/runs/13332177764?pr=15841
[4] detection results exposed indirectly in `curl_config.h`:
- `HAVE_FILE_OFFSET_BITS` via `_FILE_OFFSET_BITS`
- `HAVE_GETHOSTBYNAME_R_*_REENTRANT` via `NEED_REENTRANT`
- `HAVE_SOCKADDR_IN6_SIN6_ADDR` via `USE_IPV6`
Closes #15841
225 lines
7.0 KiB
Makefile
225 lines
7.0 KiB
Makefile
#***************************************************************************
|
|
# _ _ ____ _
|
|
# Project ___| | | | _ \| |
|
|
# / __| | | | |_) | |
|
|
# | (__| |_| | _ <| |___
|
|
# \___|\___/|_| \_\_____|
|
|
#
|
|
# Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
#
|
|
# This software is licensed as described in the file COPYING, which
|
|
# you should have received as part of this distribution. The terms
|
|
# are also available at https://curl.se/docs/copyright.html.
|
|
#
|
|
# You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
# copies of the Software, and permit persons to whom the Software is
|
|
# furnished to do so, under the terms of the COPYING file.
|
|
#
|
|
# This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
# KIND, either express or implied.
|
|
#
|
|
# SPDX-License-Identifier: curl
|
|
#
|
|
###########################################################################
|
|
|
|
AUTOMAKE_OPTIONS = foreign
|
|
|
|
ACLOCAL_AMFLAGS = -I m4
|
|
|
|
CMAKE_DIST = \
|
|
CMake/cmake_uninstall.cmake.in \
|
|
CMake/CMakeConfigurableFile.in \
|
|
CMake/curl-config.cmake.in \
|
|
CMake/CurlSymbolHiding.cmake \
|
|
CMake/CurlTests.c \
|
|
CMake/FindBearSSL.cmake \
|
|
CMake/FindBrotli.cmake \
|
|
CMake/FindCares.cmake \
|
|
CMake/FindGSS.cmake \
|
|
CMake/FindLDAP.cmake \
|
|
CMake/FindLibgsasl.cmake \
|
|
CMake/FindLibidn2.cmake \
|
|
CMake/FindLibpsl.cmake \
|
|
CMake/FindLibrtmp.cmake \
|
|
CMake/FindLibssh.cmake \
|
|
CMake/FindLibssh2.cmake \
|
|
CMake/FindLibuv.cmake \
|
|
CMake/FindMbedTLS.cmake \
|
|
CMake/FindMSH3.cmake \
|
|
CMake/FindMbedTLS.cmake \
|
|
CMake/FindNGHTTP2.cmake \
|
|
CMake/FindNGHTTP3.cmake \
|
|
CMake/FindNGTCP2.cmake \
|
|
CMake/FindNettle.cmake \
|
|
CMake/FindQuiche.cmake \
|
|
CMake/FindRustls.cmake \
|
|
CMake/FindWolfSSH.cmake \
|
|
CMake/FindWolfSSL.cmake \
|
|
CMake/FindZstd.cmake \
|
|
CMake/Macros.cmake \
|
|
CMake/OtherTests.cmake \
|
|
CMake/PickyWarnings.cmake \
|
|
CMake/Utilities.cmake \
|
|
CMake/unix-cache.cmake \
|
|
CMake/win32-cache.cmake \
|
|
CMakeLists.txt \
|
|
tests/cmake/CMakeLists.txt \
|
|
tests/cmake/test.c \
|
|
tests/cmake/test.sh
|
|
|
|
VC_DIST = projects/README.md \
|
|
projects/build-openssl.bat \
|
|
projects/checksrc.bat \
|
|
projects/generate.bat
|
|
|
|
WINBUILD_DIST = winbuild/README.md \
|
|
winbuild/MakefileBuild.vc winbuild/Makefile.vc winbuild/makedebug.bat
|
|
|
|
PLAN9_DIST = plan9/include/mkfile \
|
|
plan9/include/mkfile \
|
|
plan9/mkfile.proto \
|
|
plan9/mkfile \
|
|
plan9/README \
|
|
plan9/lib/mkfile.inc \
|
|
plan9/lib/mkfile \
|
|
plan9/src/mkfile.inc \
|
|
plan9/src/mkfile
|
|
|
|
EXTRA_DIST = CHANGES.md COPYING RELEASE-NOTES Dockerfile \
|
|
$(CMAKE_DIST) $(VC_DIST) $(WINBUILD_DIST) $(PLAN9_DIST)
|
|
|
|
DISTCLEANFILES = buildinfo.txt
|
|
|
|
bin_SCRIPTS = curl-config
|
|
|
|
SUBDIRS = lib docs src scripts
|
|
DIST_SUBDIRS = $(SUBDIRS) tests packages include docs
|
|
|
|
pkgconfigdir = $(libdir)/pkgconfig
|
|
pkgconfig_DATA = libcurl.pc
|
|
|
|
dist-hook:
|
|
rm -rf $(top_builddir)/tests/log
|
|
find $(distdir) -name "*.dist" -exec rm {} \;
|
|
(distit=`find $(srcdir) -name "*.dist" | grep -v Makefile`; \
|
|
for file in $$distit; do \
|
|
strip=`echo $$file | sed -e s/^$(srcdir)// -e s/\.dist//`; \
|
|
cp -p $$file $(distdir)$$strip; \
|
|
done)
|
|
|
|
check: test examples check-docs
|
|
|
|
if CROSSCOMPILING
|
|
test-full: test
|
|
test-nonflaky: test
|
|
test-torture: test
|
|
test-event: test
|
|
test-am: test
|
|
test-ci: test
|
|
pytest: test
|
|
pytest-ci: test
|
|
|
|
test:
|
|
@echo "NOTICE: we can't run the tests when cross-compiling!"
|
|
|
|
else
|
|
|
|
test:
|
|
@(cd tests; $(MAKE) all quiet-test)
|
|
|
|
test-full:
|
|
@(cd tests; $(MAKE) all full-test)
|
|
|
|
test-nonflaky:
|
|
@(cd tests; $(MAKE) all nonflaky-test)
|
|
|
|
test-torture:
|
|
@(cd tests; $(MAKE) all torture-test)
|
|
|
|
test-event:
|
|
@(cd tests; $(MAKE) all event-test)
|
|
|
|
test-am:
|
|
@(cd tests; $(MAKE) all am-test)
|
|
|
|
test-ci:
|
|
@(cd tests; $(MAKE) all ci-test)
|
|
|
|
pytest:
|
|
@(cd tests; $(MAKE) all default-pytest)
|
|
|
|
pytest-ci:
|
|
@(cd tests; $(MAKE) all ci-pytest)
|
|
|
|
endif
|
|
|
|
examples:
|
|
@(cd docs/examples; $(MAKE) check)
|
|
|
|
check-docs:
|
|
@(cd docs/libcurl; $(MAKE) check)
|
|
|
|
# Build source and binary rpms. For rpm-3.0 and above, the ~/.rpmmacros
|
|
# must contain the following line:
|
|
# %_topdir /home/loic/local/rpm
|
|
# and that /home/loic/local/rpm contains the directory SOURCES, BUILD etc.
|
|
#
|
|
# cd /home/loic/local/rpm ; mkdir -p SOURCES BUILD RPMS/i386 SPECS SRPMS
|
|
#
|
|
# If additional configure flags are needed to build the package, add the
|
|
# following in ~/.rpmmacros
|
|
# %configure CFLAGS="%{optflags}" ./configure %{_target_platform} --prefix=%{_prefix} ${AM_CONFIGFLAGS}
|
|
# and run make rpm in the following way:
|
|
# AM_CONFIGFLAGS='--with-uri=/home/users/loic/local/RedHat-6.2' make rpm
|
|
#
|
|
|
|
rpms:
|
|
$(MAKE) RPMDIST=curl rpm
|
|
$(MAKE) RPMDIST=curl-ssl rpm
|
|
|
|
rpm:
|
|
RPM_TOPDIR=`rpm --showrc | $(PERL) -n -e 'print if(s/.*_topdir\s+(.*)/$$1/)'` ; \
|
|
cp $(srcdir)/packages/Linux/RPM/$(RPMDIST).spec $$RPM_TOPDIR/SPECS ; \
|
|
cp $(PACKAGE)-$(VERSION).tar.gz $$RPM_TOPDIR/SOURCES ; \
|
|
rpm -ba --clean --rmsource $$RPM_TOPDIR/SPECS/$(RPMDIST).spec ; \
|
|
mv $$RPM_TOPDIR/RPMS/i386/$(RPMDIST)-*.rpm . ; \
|
|
mv $$RPM_TOPDIR/SRPMS/$(RPMDIST)-*.src.rpm .
|
|
|
|
# We extend the standard install with a custom hook:
|
|
if BUILD_DOCS
|
|
install-data-hook:
|
|
(cd include && $(MAKE) install)
|
|
(cd docs && $(MAKE) install)
|
|
(cd docs/libcurl && $(MAKE) install)
|
|
else
|
|
install-data-hook:
|
|
(cd include && $(MAKE) install)
|
|
(cd docs && $(MAKE) install)
|
|
endif
|
|
|
|
# We extend the standard uninstall with a custom hook:
|
|
uninstall-hook:
|
|
(cd include && $(MAKE) uninstall)
|
|
(cd docs && $(MAKE) uninstall)
|
|
(cd docs/libcurl && $(MAKE) uninstall)
|
|
|
|
ca-bundle: $(srcdir)/scripts/mk-ca-bundle.pl
|
|
@echo "generating a fresh ca-bundle.crt"
|
|
@perl $(srcdir)/scripts/mk-ca-bundle.pl -b -l -u lib/ca-bundle.crt
|
|
|
|
ca-firefox: $(srcdir)/scripts/firefox-db2pem.sh
|
|
@echo "generating a fresh ca-bundle.crt"
|
|
$(srcdir)/scripts/firefox-db2pem.sh lib/ca-bundle.crt
|
|
|
|
checksrc:
|
|
(cd lib && $(MAKE) checksrc)
|
|
(cd src && $(MAKE) checksrc)
|
|
(cd tests && $(MAKE) checksrc)
|
|
(cd include/curl && $(MAKE) checksrc)
|
|
(cd docs/examples && $(MAKE) checksrc)
|
|
(cd packages && $(MAKE) checksrc)
|
|
|
|
tidy:
|
|
(cd src && $(MAKE) tidy)
|
|
(cd lib && $(MAKE) tidy)
|