luo980/curl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tool_getparam: stop supporting @filename style for --cookie

Browse Source 
The `@filename` style was never documented for --cookie <data|filename>
but prior to this change curl would accept it anyway and always treat a
@ prefixed string as a filename.

That's a problem if the string also contains a = sign because then it is
documented to be interpreted as a cookie string and not a filename.

Example:

`--cookie @foo=bar`

Before: Interpreted as load cookies from filename foo=bar.

After: Interpreted as cookie `@foo=bar` (name `@foo` and value `bar`).

Other curl options with a data/filename option-value use the `@filename`
to distinguish filenames which is probably how this happened. The
--cookie option has never been documented that way.

Ref: https://curl.se/docs/manpage.html#-b

Closes https://github.com/curl/curl/pull/12645
This commit is contained in:
Jay Satiro 2024-01-07 00:07:55 -05:00
parent 3378d2bd09
commit f4606a796e
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/tool_getparam.c
View File

@ -1988,16 +1988,15 @@ ParameterError getparameter(const char *flag, /* f or -long-flag */
err = getstr(&config->hsts, nextarg, ALLOW_BLANK);
break;
case C_COOKIE: /* --cookie */
if(nextarg[0] == '@') {
nextarg++;
}
else if(strchr(nextarg, '=')) {
if(strchr(nextarg, '=')) {
/* A cookie string must have a =-letter */
err = add2list(&config->cookies, nextarg);
break;
}
/* We have a cookie file to read from! */
err = add2list(&config->cookiefiles, nextarg);
else {
/* We have a cookie file to read from! */
err = add2list(&config->cookiefiles, nextarg);
}
break;
case C_USE_ASCII: /* --use-ascii */
config->use_ascii = toggle;