luo980/curl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

unit1604: fix snprintf

Browse Source 
follow-up to 0326b06

sizeof(pointer) is no good for the buffer size!

Reported-by: Viktor Szakats
This commit is contained in:
Daniel Stenberg 2016-04-03 10:46:36 +02:00
parent 0326b06770
commit d4d87d7ead
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/unit/unit1604.c
View File

@ -45,7 +45,7 @@ static void unit_stop(void)
static char *getflagstr(int flags) {
char *buf = malloc(256);
fail_unless(buf, "out of memory");
snprintf(buf, sizeof(buf), "%s,%s,%s,%s",
snprintf(buf, 256, "%s,%s,%s,%s",
((flags & SANITIZE_ALLOW_COLONS) ? "SANITIZE_ALLOW_COLONS" : ""),
((flags & SANITIZE_ALLOW_PATH) ? "SANITIZE_ALLOW_PATH" : ""),
((flags & SANITIZE_ALLOW_RESERVED) ? "SANITIZE_ALLOW_RESERVED" : ""),
@ -56,7 +56,7 @@ static char *getflagstr(int flags) {
static char *getcurlcodestr(int cc) {
char *buf = malloc(256);
fail_unless(buf, "out of memory");
snprintf(buf, sizeof(buf), "%s (%d)",
snprintf(buf, 256, "%s (%d)",
(cc == SANITIZE_ERR_OK ? "SANITIZE_ERR_OK" :
cc == SANITIZE_ERR_BAD_ARGUMENT ? "SANITIZE_ERR_BAD_ARGUMENT" :
cc == SANITIZE_ERR_INVALID_PATH ? "SANITIZE_ERR_INVALID_PATH" :