luo980/curl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

connecache: remove duplicate connc->closure_handle check

Browse Source 
The superfluous extra check could cause analyzer false positives
and doesn't serve any purpose.

Closes #8676
This commit is contained in:
Daniel Stenberg 2022-04-06 08:32:03 +02:00
parent ba83c522f5
commit d4cf98bbd1
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/conncache.c
View File

@ -531,6 +531,7 @@ void Curl_conncache_close_all_connections(struct conncache *connc)
{ {
struct connectdata *conn; struct connectdata *conn;
char buffer[READBUFFER_MIN + 1]; char buffer[READBUFFER_MIN + 1];
SIGPIPE_VARIABLE(pipe_st);
if(!connc->closure_handle) if(!connc->closure_handle)
return; return;
connc->closure_handle->state.buffer = buffer; connc->closure_handle->state.buffer = buffer;
@ -538,7 +539,6 @@ void Curl_conncache_close_all_connections(struct conncache *connc)
conn = conncache_find_first_connection(connc); conn = conncache_find_first_connection(connc);
while(conn) { while(conn) {
SIGPIPE_VARIABLE(pipe_st);
sigpipe_ignore(connc->closure_handle, &pipe_st); sigpipe_ignore(connc->closure_handle, &pipe_st);
/* This will remove the connection from the cache */ /* This will remove the connection from the cache */
connclose(conn, "kill all"); connclose(conn, "kill all");
@ -550,15 +550,12 @@ void Curl_conncache_close_all_connections(struct conncache *connc)
} }
connc->closure_handle->state.buffer = NULL; connc->closure_handle->state.buffer = NULL;
if(connc->closure_handle) {
SIGPIPE_VARIABLE(pipe_st);
sigpipe_ignore(connc->closure_handle, &pipe_st); sigpipe_ignore(connc->closure_handle, &pipe_st);
Curl_hostcache_clean(connc->closure_handle, Curl_hostcache_clean(connc->closure_handle,
connc->closure_handle->dns.hostcache); connc->closure_handle->dns.hostcache);
Curl_close(&connc->closure_handle); Curl_close(&connc->closure_handle);
sigpipe_restore(&pipe_st); sigpipe_restore(&pipe_st);
}
} }
#if 0 #if 0