From c4b8ec495d534e15e919c0e47b7e2d3086443ccf Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Sat, 12 Jun 2021 18:37:52 +0200 Subject: [PATCH] asyn-ares: remove check for 'data' in Curl_resolver_cancel It implied it would survive a NULL in there which it won't. Instead do an assert. Pointed out by scan-build. Closes #7248 --- lib/asyn-ares.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/asyn-ares.c b/lib/asyn-ares.c index 9ee307beb0..839fabb86a 100644 --- a/lib/asyn-ares.c +++ b/lib/asyn-ares.c @@ -206,7 +206,8 @@ static void destroy_async_data(struct Curl_async *async); */ void Curl_resolver_cancel(struct Curl_easy *data) { - if(data && data->state.async.resolver) + DEBUGASSERT(data); + if(data->state.async.resolver) ares_cancel((ares_channel)data->state.async.resolver); destroy_async_data(&data->state.async); }