luo980/curl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

quiche: avoid NULL deref in debug logging

Browse Source 
Coverity reported "Dereference after null check"

If stream is NULL and the function exits, the logging must not deref it.

Closes #11454
This commit is contained in:
Daniel Stenberg 2023-07-17 20:51:17 +02:00
parent 380fe02cf5
commit a141c3c08b
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/vquic/curl_quiche.c
View File

@ -885,7 +885,8 @@ out:
ctx->data_recvd += nread; ctx->data_recvd += nread;
DEBUGF(LOG_CF(data, cf, "[h3sid=%"PRId64"] cf_recv(total=%" DEBUGF(LOG_CF(data, cf, "[h3sid=%"PRId64"] cf_recv(total=%"
CURL_FORMAT_CURL_OFF_T ") -> %zd, %d", CURL_FORMAT_CURL_OFF_T ") -> %zd, %d",
stream->id, ctx->data_recvd, nread, *err)); stream ? stream->id : (int64_t)0,
ctx->data_recvd, nread, *err));
return nread; return nread;
} }