diff --git a/docs/CODE_REVIEW.md b/docs/CODE_REVIEW.md index e6a28a6009..b18f4a6075 100644 --- a/docs/CODE_REVIEW.md +++ b/docs/CODE_REVIEW.md @@ -36,9 +36,9 @@ Changing the API and the ABI may be fine in a change but it needs to be done deliberately and carefully. If not, a reviewer must help the author to realize the mistake. -curl and libcurl are similarly very strict on not modifying existing -behavior. API and ABI stability is not enough, the behavior should also remain -intact as far as possible. +curl and libcurl are similarly strict on not modifying existing behavior. API +and ABI stability is not enough, the behavior should also remain intact as far +as possible. ## Code style diff --git a/docs/CODE_STYLE.md b/docs/CODE_STYLE.md index 8ba1e038d5..6e2b1e2bdc 100644 --- a/docs/CODE_STYLE.md +++ b/docs/CODE_STYLE.md @@ -2,7 +2,7 @@ Source code that has a common style is easier to read than code that uses different styles in different places. It helps making the code feel like one -single code base. Easy-to-read is a very important property of code and helps +single code base. Easy-to-read is an important property of code and helps making it easier to review when new things are added and it helps debugging code when developers are trying to figure out why things go wrong. A unified style is more important than individual contributors having their own personal @@ -56,10 +56,10 @@ introduced in the C standard until C99. We use only __/* comments */__. ## Long lines Source code in curl may never be wider than 79 columns and there are two -reasons for maintaining this even in the modern era of very large and high +reasons for maintaining this even in the modern era of large and high resolution screens: -1. Narrower columns are easier to read than very wide ones. There's a reason +1. Narrower columns are easier to read than wide ones. There's a reason newspapers have used columns for decades or centuries. 2. Narrower columns allow developers to easier show multiple pieces of code @@ -154,8 +154,8 @@ if(!ptr) ## New block on a new line -We never write multiple statements on the same source line, even for very -short if() conditions. +We never write multiple statements on the same source line, even for short +if() conditions. ```c if(a) diff --git a/docs/CONTRIBUTE.md b/docs/CONTRIBUTE.md index 4d278b2193..8469b60434 100644 --- a/docs/CONTRIBUTE.md +++ b/docs/CONTRIBUTE.md @@ -96,9 +96,9 @@ and regression in the future. ### Patch Against Recent Sources Please try to get the latest available sources to make your patches against. -It makes the lives of the developers so much easier. The very best is if you -get the most up-to-date sources from the git repository, but the latest -release archive is quite OK as well! +It makes the lives of the developers so much easier. The best is if you get +the most up-to-date sources from the git repository, but the latest release +archive is quite OK as well! ### Documentation @@ -120,8 +120,8 @@ in the test suite. Every feature that is added should get at least one valid test case that verifies that it works as documented. If every submitter also posts a few test cases, it won't end up as a heavy burden on a single person! -If you don't have test cases or perhaps you have done something that is very -hard to write tests for, do explain exactly how you have otherwise tested and +If you don't have test cases or perhaps you have done something that is hard +to write tests for, do explain exactly how you have otherwise tested and verified your changes. ## Sharing Your Changes @@ -139,9 +139,9 @@ risks stalling and eventually just getting deleted without action. As a submitter of a change, you are the owner of that change until it has been merged. Respond on the list or on github about the change and answer questions and/or -fix nits/flaws. This is very important. We will take lack of replies as a -sign that you're not very anxious to get your patch accepted and we tend to -simply drop such changes. +fix nits/flaws. This is important. We will take lack of replies as a sign that +you're not anxious to get your patch accepted and we tend to simply drop such +changes. ### About pull requests @@ -242,9 +242,9 @@ you commit ### Write Access to git Repository -If you are a very frequent contributor, you may be given push access to the -git repository and then you'll be able to push your changes straight into the -git repo instead of sending changes as pull requests or by mail as patches. +If you are a frequent contributor, you may be given push access to the git +repository and then you'll be able to push your changes straight into the git +repo instead of sending changes as pull requests or by mail as patches. Just ask if this is what you'd want. You will be required to have posted several high quality patches first, before you can be granted push access. diff --git a/docs/FAQ b/docs/FAQ index 3e029ee870..1f323e7bd9 100644 --- a/docs/FAQ +++ b/docs/FAQ @@ -215,15 +215,15 @@ FAQ another tool that uses libcurl. We do not add things to curl that other small and available tools already do - very well at the side. curl's output can be piped into another program or + well at the side. curl's output can be piped into another program or redirected to another file for the next program to interpret. We focus on protocol related issues and improvements. If you want to do more - magic with the supported protocols than curl currently does, chances are good - we will agree. If you want to add more protocols, we may very well agree. + magic with the supported protocols than curl currently does, chances are + good we will agree. If you want to add more protocols, we may agree. If you want someone else to do all the work while you wait for us to - implement it for you, that is not a very friendly attitude. We spend a + implement it for you, that is not a friendly attitude. We spend a considerable time already on maintaining and developing curl. In order to get more out of us, you should consider trading in some of your time and effort in return. Simply go to the GitHub repo which resides at @@ -407,14 +407,14 @@ FAQ The reason why static libraries is much harder to deal with is that for them we don't get any help but the script itself must know or check what more libraries that are needed (with shared libraries, that dependency "chain" is - handled automatically). This is a very error-prone process and one that also + handled automatically). This is a error-prone process and one that also tends to vary over time depending on the release versions of the involved components and may also differ between operating systems. - For that reason, configure does very little attempts to actually figure this - out and you are instead encouraged to set LIBS and LDFLAGS accordingly when - you invoke configure, and point out the needed libraries and set the - necessary flags yourself. + For that reason, configure does few attempts to actually figure this out and + you are instead encouraged to set LIBS and LDFLAGS accordingly when you + invoke configure, and point out the needed libraries and set the necessary + flags yourself. 2.2 Does curl work with other SSL libraries? @@ -878,7 +878,7 @@ FAQ Also note that regular HTTP (using Basic authentication) and FTP passwords are sent as cleartext across the network. All it takes for anyone to fetch - them is to listen on the network. Eavesdropping is very easy. Use more secure + them is to listen on the network. Eavesdropping is easy. Use more secure authentication methods (like Digest, Negotiate or even NTLM) or consider the SSL-based alternatives HTTPS and FTPS. @@ -988,7 +988,7 @@ FAQ 4.16 My HTTP POST or PUT requests are slow! libcurl makes all POST and PUT requests (except for POST requests with a - very tiny request body) use the "Expect: 100-continue" header. This header + tiny request body) use the "Expect: 100-continue" header. This header allows the server to deny the operation early so that libcurl can bail out before having to send any data. This is useful in authentication cases and others. @@ -1392,10 +1392,10 @@ FAQ 6. License Issues - curl and libcurl are released under a MIT/X derivative license. The license is - very liberal and should not impose a problem for your project. This section - is just a brief summary for the cases we get the most questions. (Parts of - this section was much enhanced by Bjorn Reese.) + curl and libcurl are released under a MIT/X derivative license. The license + is liberal and should not impose a problem for your project. This section is + just a brief summary for the cases we get the most questions. (Parts of this + section was much enhanced by Bjorn Reese.) We are not lawyers and this is not legal advice. You should probably consult one if you want true and accurate legal insights without our prejudice. Note diff --git a/docs/HELP-US.md b/docs/HELP-US.md index 2578451900..714fef30d4 100644 --- a/docs/HELP-US.md +++ b/docs/HELP-US.md @@ -19,7 +19,7 @@ down and report the bug. Or make your first pull request with a fix for that. Some projects mark small issues as "beginner friendly", "bite-sized" or similar. We don't do that in curl since such issues never linger around long -enough. Simple issues get handled very fast. +enough. Simple issues get handled fast. If you're looking for a smaller or simpler task in the project to help out with as an entry-point into the project, perhaps because you are a newcomer or diff --git a/docs/HTTP-COOKIES.md b/docs/HTTP-COOKIES.md index 2ef1a60a08..76e3dcb694 100644 --- a/docs/HTTP-COOKIES.md +++ b/docs/HTTP-COOKIES.md @@ -14,7 +14,7 @@ Cookies are set to the client with the Set-Cookie: header and are sent to servers with the Cookie: header. - For a very long time, the only spec explaining how to use cookies was the + For a long time, the only spec explaining how to use cookies was the original [Netscape spec from 1994](https://curl.se/rfc/cookie_spec.html). In 2011, [RFC6265](https://www.ietf.org/rfc/rfc6265.txt) was finally diff --git a/docs/INTERNALS.md b/docs/INTERNALS.md index 176ca52577..3af7606488 100644 --- a/docs/INTERNALS.md +++ b/docs/INTERNALS.md @@ -467,7 +467,7 @@ Return Codes and Informationals I've made things simple. Almost every function in libcurl returns a CURLcode, that must be `CURLE_OK` if everything is OK or otherwise a suitable error - code as the `curl/curl.h` include file defines. The very spot that detects an + code as the `curl/curl.h` include file defines. The place that detects an error must use the `Curl_failf()` function to set the human-readable error description. @@ -797,7 +797,7 @@ Track Down Memory Leaks tests/memanalyze.pl dump This now outputs a report on what resources that were allocated but never - freed etc. This report is very fine for posting to the list! + freed etc. This report is fine for posting to the list! If this doesn't produce any output, no leak was detected in libcurl. Then the leak is mostly likely to be in your code. @@ -812,8 +812,7 @@ Track Down Memory Leaks 1. The application can use whatever event system it likes as it gets info from libcurl about what file descriptors libcurl waits for what action - on. (The previous API returns `fd_sets` which is very - `select()`-centric). + on. (The previous API returns `fd_sets` which is `select()`-centric). 2. When the application discovers action on a single socket, it calls libcurl and informs that there was action on this particular socket and diff --git a/docs/KNOWN_BUGS b/docs/KNOWN_BUGS index 173fe4c9e1..46a02aedc5 100644 --- a/docs/KNOWN_BUGS +++ b/docs/KNOWN_BUGS @@ -288,7 +288,7 @@ problems may have been fixed or changed somewhat since this was written! get "good" random) so applications trying to avoid the init for performance reasons would do wrong anyway - D) never very carefully documented so all this mostly just happened to work + D) not documented carefully so all this mostly just happened to work for some users However, in spite of the problems with the feature, there were some users who @@ -529,10 +529,10 @@ problems may have been fixed or changed somewhat since this was written! 5.12 flaky Windows CI builds We run many CI builds for each commit and PR on github, and especially a - number of the Windows builds are very flaky. This means that we rarely get - all CI builds go green and complete without errors. This is very unfortunate - as it makes us sometimes miss actual build problems and it is surprising to - newcomers to the project who (rightfully) don't expect this. + number of the Windows builds are flaky. This means that we rarely get all CI + builds go green and complete without errors. This is unfortunate as it makes + us sometimes miss actual build problems and it is surprising to newcomers to + the project who (rightfully) don't expect this. See https://github.com/curl/curl/issues/6972 diff --git a/docs/MAIL-ETIQUETTE b/docs/MAIL-ETIQUETTE index 80d06b6406..63bf63e580 100644 --- a/docs/MAIL-ETIQUETTE +++ b/docs/MAIL-ETIQUETTE @@ -39,9 +39,9 @@ MAIL ETIQUETTE Each mailing list is targeted to a specific set of users and subjects, please use the one or the ones that suit you the most. - Each mailing list has hundreds up to thousands of readers, meaning that - each mail sent will be received and read by a very large number of people. - People from various cultures, regions, religions and continents. + Each mailing list has hundreds up to thousands of readers, meaning that each + mail sent will be received and read by a large number of people. People + from various cultures, regions, religions and continents. 1.2 Netiquette @@ -133,16 +133,16 @@ MAIL ETIQUETTE send the email, your post will just be silently discarded. If you posted for the first time to the mailing list, you first need to wait - for an administrator to allow your email to go through (moderated). This normally - happens very quickly but in case we're asleep, you may have to wait a few - hours. + for an administrator to allow your email to go through (moderated). This + normally happens quickly but in case we're asleep, you may have to wait a + few hours. Once your email goes through it is sent out to several hundred or even - thousands of recipients. Your email may cover an area that not that many people - know about or are interested in. Or possibly the person who knows about it - is on vacation or under a very heavy work load right now. You may have to wait - for a response and you should not expect to get a response at all, but - hopefully you get an answer within a couple of days. + thousands of recipients. Your email may cover an area that not that many + people know about or are interested in. Or possibly the person who knows + about it is on vacation or under a heavy work load right now. You may have + to wait for a response and you should not expect to get a response at all, + but hopefully you get an answer within a couple of days. You do yourself and all of us a service when you include as many details as possible already in your first email. Mention your operating system and diff --git a/docs/MANUAL.md b/docs/MANUAL.md index a637c66c0a..ae0cf6973e 100644 --- a/docs/MANUAL.md +++ b/docs/MANUAL.md @@ -275,8 +275,8 @@ Store the HTTP headers in a separate file (headers.txt in the example): curl --dump-header headers.txt curl.se -Note that headers stored in a separate file can be very useful at a later time -if you want curl to use cookies sent by the server. More about that in the +Note that headers stored in a separate file can be useful at a later time if +you want curl to use cookies sent by the server. More about that in the cookies section. ## POST (HTTP) @@ -509,8 +509,8 @@ second for 1 minute, run: curl -Y 3000 -y 60 www.far-away-site.com -This can very well be used in combination with the overall time limit, so -that the above operation must be completed in whole within 30 minutes: +This can be used in combination with the overall time limit, so that the above +operation must be completed in whole within 30 minutes: curl -m 1800 -Y 3000 -y 60 www.far-away-site.com @@ -583,9 +583,9 @@ tables etc: ## Extra Headers -When using curl in your own very special programs, you may end up needing -to pass on your own custom headers when getting a web page. You can do -this by using the `-H` flag. +When using curl in your own programs, you may end up needing to pass on your +own custom headers when getting a web page. You can do this by using the `-H` +flag. Example, send the header `X-you-and-me: yes` to the server when getting a page: @@ -608,8 +608,8 @@ directory at your ftp site, do: curl ftp://user:passwd@my.site.com/README -But if you want the README file from the root directory of that very same -site, you need to specify the absolute file name: +But if you want the README file from the root directory of that same site, you +need to specify the absolute file name: curl ftp://user:passwd@my.site.com//README @@ -839,7 +839,7 @@ Curl supports `.netrc` files if told to (using the `-n`/`--netrc` and `--netrc-optional` options). This is not restricted to just FTP, so curl can use it for all protocols where authentication is used. -A very simple `.netrc` file could look something like: +A simple `.netrc` file could look something like: machine curl.se login iamdaniel password mysecret @@ -869,9 +869,9 @@ curl ask for one and you already entered the real password to kinit/kauth. ## TELNET -The curl telnet support is basic and very easy to use. Curl passes all data -passed to it on stdin to the remote server. Connect to a remote telnet server -using a command line similar to: +The curl telnet support is basic and easy to use. Curl passes all data passed +to it on stdin to the remote server. Connect to a remote telnet server using a +command line similar to: curl telnet://remote.server.com diff --git a/docs/SECURITY-PROCESS.md b/docs/SECURITY-PROCESS.md index 383d0c0702..3a909b468b 100644 --- a/docs/SECURITY-PROCESS.md +++ b/docs/SECURITY-PROCESS.md @@ -99,11 +99,11 @@ This is a private mailing list for discussions on and about curl security issues. Who is on this list? There are a couple of criteria you must meet, and then we -might ask you to join the list or you can ask to join it. It really isn't very -formal. We basically only require that you have a long-term presence in the -curl project and you have shown an understanding for the project and its way -of working. You must've been around for a good while and you should have no -plans in vanishing in the near future. +might ask you to join the list or you can ask to join it. It really isn't a +formal process. We basically only require that you have a long-term presence +in the curl project and you have shown an understanding for the project and +its way of working. You must've been around for a good while and you should +have no plans in vanishing in the near future. We do not make the list of participants public mostly because it tends to vary somewhat over time and a list somewhere will only risk getting outdated. diff --git a/docs/TODO b/docs/TODO index eb7f75b47f..4ae909a763 100644 --- a/docs/TODO +++ b/docs/TODO @@ -832,7 +832,7 @@ CURLOPT_PINNEDPUBLICKEY does not consider the hashes of intermediate & root certificates when comparing the pinned keys. Therefore it is not compatible with "HTTP Public Key Pinning" as there also intermediate and root - certificates can be pinned. This is very useful as it prevents webadmins from + certificates can be pinned. This is useful as it prevents webadmins from "locking themselves out of their servers". Adding this feature would make curls pinning 100% compatible to HPKP and @@ -981,8 +981,8 @@ 18.6 Option to make -Z merge lined based outputs on stdout When a user requests multiple lined based files using -Z and sends them to - stdout, curl will not "merge" and send complete lines fine but may very well - send partial lines from several sources. + stdout, curl will not "merge" and send complete lines fine but may send + partial lines from several sources. https://github.com/curl/curl/issues/5175 diff --git a/docs/TheArtOfHttpScripting.md b/docs/TheArtOfHttpScripting.md index a6eb8b3541..054c6267bd 100644 --- a/docs/TheArtOfHttpScripting.md +++ b/docs/TheArtOfHttpScripting.md @@ -21,7 +21,7 @@ ## The HTTP Protocol - HTTP is the protocol used to fetch data from web servers. It is a very simple + HTTP is the protocol used to fetch data from web servers. It is a simple protocol that is built upon TCP/IP. The protocol also allows information to get sent to the server from the client using a few different methods, as will be shown here. @@ -252,13 +252,13 @@ your browser. That's generally a good thing when you want to be able to bookmark that page with your given data, but it is an obvious disadvantage if you entered secret information in one of the fields or if there are a large - amount of fields creating a very long and unreadable URL. + amount of fields creating a long and unreadable URL. The HTTP protocol then offers the POST method. This way the client sends the data separated from the URL and thus you won't see any of it in the URL address field. - The form would look very similar to the previous one: + The form would look similar to the previous one: ```html