luo980/curl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

request: make Curl_req_init return void

Browse Source 
Since it could not return error and therefore this change removes dead
code for the caller.

Spotted by CodeSonar.

Closes #13423
This commit is contained in:
Daniel Stenberg 2024-04-19 10:46:42 +02:00
parent 25236c6a80
commit 926fb00405
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
3 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/request.c
View File

@ -40,10 +40,9 @@
#include "curl_memory.h"
#include "memdebug.h"
CURLcode Curl_req_init(struct SingleRequest *req)
void Curl_req_init(struct SingleRequest *req)
{
memset(req, 0, sizeof(*req));
return CURLE_OK;
}
CURLcode Curl_req_soft_reset(struct SingleRequest *req,

2
lib/request.h
View File

@ -152,7 +152,7 @@ struct SingleRequest {
/**
* Initialize the state of the request for first use.
*/
CURLcode Curl_req_init(struct SingleRequest *req);
void Curl_req_init(struct SingleRequest *req);
/**
* The request is about to start. Record time and do a soft reset.

7
lib/url.c
View File

@ -516,12 +516,7 @@ CURLcode Curl_open(struct Curl_easy **curl)
data->magic = CURLEASY_MAGIC_NUMBER;
result = Curl_req_init(&data->req);
if(result) {
DEBUGF(fprintf(stderr, "Error: request init failed\n"));
free(data);
return result;
}
Curl_req_init(&data->req);
result = Curl_resolver_init(data, &data->state.async.resolver);
if(result) {