diff --git a/CMake/PickyWarnings.cmake b/CMake/PickyWarnings.cmake index 516246111f..cfe82b6db1 100644 --- a/CMake/PickyWarnings.cmake +++ b/CMake/PickyWarnings.cmake @@ -108,7 +108,7 @@ if(PICKY_COMPILER) -Wold-style-definition # clang 2.7 gcc 3.4 -Wredundant-decls # clang 2.7 gcc 4.1 -Wsign-conversion # clang 2.9 gcc 4.3 - -Wno-error=sign-conversion # FIXME + -Wno-error=sign-conversion -Wstrict-prototypes # clang 1.0 gcc 3.3 # -Wswitch-enum # clang 2.7 gcc 4.1 # Not used: It basically disallows default case -Wtype-limits # clang 2.7 gcc 4.3 diff --git a/lib/curl_setup.h b/lib/curl_setup.h index b46b672d44..1727e2d794 100644 --- a/lib/curl_setup.h +++ b/lib/curl_setup.h @@ -31,7 +31,7 @@ /* Tell "curl/curl.h" not to include "curl/mprintf.h" */ #define CURL_SKIP_INCLUDE_MPRINTF -/* FIXME: Delete this once the warnings have been fixed. */ +/* Make these warnings visible with an option. */ #if !defined(CURL_WARN_SIGN_CONVERSION) #if defined(__GNUC__) || defined(__clang__) #pragma GCC diagnostic ignored "-Wsign-conversion" diff --git a/m4/curl-compilers.m4 b/m4/curl-compilers.m4 index 994eb9c522..bb20b6ced9 100644 --- a/m4/curl-compilers.m4 +++ b/m4/curl-compilers.m4 @@ -844,7 +844,7 @@ AC_DEFUN([CURL_SET_COMPILER_WARNING_OPTS], [ dnl Only clang 2.9 or later if test "$compiler_num" -ge "209"; then CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [sign-conversion]) - tmp_CFLAGS="$tmp_CFLAGS -Wno-error=sign-conversion" # FIXME + tmp_CFLAGS="$tmp_CFLAGS -Wno-error=sign-conversion" CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [shift-sign-overflow]) # CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [padded]) # Not used because we cannot change public structs fi @@ -1032,7 +1032,7 @@ AC_DEFUN([CURL_SET_COMPILER_WARNING_OPTS], [ CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [clobbered ignored-qualifiers]) CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [conversion trampolines]) CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [sign-conversion]) - tmp_CFLAGS="$tmp_CFLAGS -Wno-error=sign-conversion" # FIXME + tmp_CFLAGS="$tmp_CFLAGS -Wno-error=sign-conversion" CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [vla]) dnl required for -Warray-bounds, included in -Wall tmp_CFLAGS="$tmp_CFLAGS -ftree-vrp"