diff --git a/scripts/checksrc.pl b/scripts/checksrc.pl index 5c279db903..c1ee27966e 100755 --- a/scripts/checksrc.pl +++ b/scripts/checksrc.pl @@ -99,13 +99,13 @@ my %warnings = ( ); sub readskiplist { - open(W, "<$dir/checksrc.skip") or return; - my @all=; + open(my $W, '<', "$dir/checksrc.skip") or return; + my @all=<$W>; for(@all) { $windows_os ? $_ =~ s/\r?\n$// : chomp; $skiplist{$_}=1; } - close(W); + close($W); } # Reads the .checksrc in $dir for any extended warnings to enable locally. @@ -381,7 +381,7 @@ sub scanfile { my $l = ""; my $prep = 0; my $prevp = 0; - open(R, "<$file") || die "failed to open $file"; + open(my $R, '<', $file) || die "failed to open $file"; my $incomment=0; my @copyright=(); @@ -389,7 +389,7 @@ sub scanfile { checksrc_clear(); # for file based ignores accept_violations(); - while() { + while(<$R>) { $windows_os ? $_ =~ s/\r?\n$// : chomp; my $l = $_; my $ol = $l; # keep the unmodified line for error reporting @@ -939,7 +939,7 @@ sub scanfile { checksrc_endoffile($file); - close(R); + close($R); }