luo980/curl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libssh2: set length to 0 if strdup failed

Browse Source 
Internally, libssh2 dereferences the NULL pointer if length is non-zero.
The callback function cannot return the error condition, so at least
prevent subsequent crash.

Closes #13213
This commit is contained in:
Tobias Stoeckmann 2024-03-28 00:38:09 +01:00 committed by Daniel Stenberg
parent 4ad9d29705
commit 6f32048200
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/vssh/libssh2.c
View File

@ -201,7 +201,8 @@ kbd_callback(const char *name, int name_len, const char *instruction,
if(num_prompts == 1) { if(num_prompts == 1) {
struct connectdata *conn = data->conn; struct connectdata *conn = data->conn;
responses[0].text = strdup(conn->passwd); responses[0].text = strdup(conn->passwd);
responses[0].length = curlx_uztoui(strlen(conn->passwd)); responses[0].length =
responses[0].text == NULL ? 0 : curlx_uztoui(strlen(conn->passwd));
} }
(void)prompts; (void)prompts;
} /* kbd_callback */ } /* kbd_callback */