luo980/curl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

asyn-thread: fix Curl_thread_create result check

Browse Source 
- Compare to curl_thread_t_null instead of 0 for error.

Currently for both supported thread libraries (pthreads and Windows)
curl_thread_t_null is defined as 0. However, the pattern throughout the
code is to check against curl_thread_t_null and not 0 since for
posterity some thread library may not use 0 for error.

Closes https://github.com/curl/curl/pull/13542
This commit is contained in:
Jay Satiro 2024-05-06 14:49:43 -04:00
parent 22cde3baa8
commit 62ae1f10e5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/asyn-thread.c
View File

@ -672,7 +672,7 @@ static bool init_resolve_thread(struct Curl_easy *data,
td->thread_hnd = Curl_thread_create(gethostbyname_thread, &td->tsd); td->thread_hnd = Curl_thread_create(gethostbyname_thread, &td->tsd);
#endif #endif
if(!td->thread_hnd) { if(td->thread_hnd == curl_thread_t_null) {
/* The thread never started, so mark it as done here for proper cleanup. */ /* The thread never started, so mark it as done here for proper cleanup. */
td->tsd.done = 1; td->tsd.done = 1;
err = errno; err = errno;