idn: more strictly check AppleIDN errors

UIDNA API returns two error values but we were only checking one.
Checking both better aligns the behaviour with that of libidn2.

Closes #14431
This commit is contained in:
Bo Anderson 2024-08-07 03:18:34 +01:00 committed by Daniel Stenberg
parent a35687831f
commit 588a6e334a
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
3 changed files with 1 additions and 11 deletions

View File

@ -85,7 +85,6 @@ problems may have been fixed or changed somewhat since this was written.
11.4 HTTP test server 'connection-monitor' problems
11.5 Connection information when using TCP Fast Open
11.6 test cases sometimes timeout
11.7 AppleIDN test failures
11.8 WinIDN test failures
12. LDAP
@ -528,12 +527,6 @@ problems may have been fixed or changed somewhat since this was written.
See https://github.com/curl/curl/issues/13350
11.7 AppleIDN test failures
Test 1035 fail on macOS when built to use AppleIDN.
See https://github.com/curl/curl/issues/14176
11.8 WinIDN test failures
Test 165 disabled when built with WinIDN.

View File

@ -106,7 +106,7 @@ static CURLcode mac_idn_to_ascii(const char *in, char **out)
(void)uidna_nameToASCII_UTF8(idna, iconv_buffer, (int)iconv_outlen,
buffer, sizeof(buffer) - 1, &info, &err);
uidna_close(idna);
if(!U_FAILURE(err)) {
if(!U_FAILURE(err) && !info.errors) {
*out = strdup(buffer);
if(*out)
return CURLE_OK;

View File

@ -93,9 +93,6 @@
%if bearssl
313
%endif
%if AppleIDN
1035
%endif
%if WinIDN
165
%endif