luo980/curl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libssh2: Print user with verbose flag

Browse Source 
This change:

 - Breaks out the existing print out of the LIBSSH2_DEBUG compile-time flag
 - Adds (single) quotation marks around the string to better expose the actual value
 - Adds a NULL print, mirroring other verbose prints in libssh2

Why was this done?

I was trying out the `sftp` option in `curl`, and found myself hitting an
issue where I was not able to get curl to tell me which username it was
using to connect to a host.

With this change, the `User: ` line is printed with `-v`, just like other
SSH verbose prints.

Instead of using the pattern used with *SSH MD5 public key*, where a
ternary is used to print `NULL` on NULL values, it is using a different
branch to add quotes around the string value.

The quotes around the string value are used to better expose to the user
an empty string value, compared to "no-value".
This commit is contained in:
Samuel Dionne-Riel 2025-02-21 14:24:48 -05:00
parent f261c8d992
commit 4697b40c0d
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/vssh/libssh2.c
View File

@ -3167,10 +3167,13 @@ static CURLcode ssh_connect(struct Curl_easy *data, bool *done)
sshc = &conn->proto.sshc;
#ifdef CURL_LIBSSH2_DEBUG
if(conn->user) {
infof(data, "User: %s", conn->user);
infof(data, "User: '%s'", conn->user);
}
else {
infof(data, "User: NULL");
}
#ifdef CURL_LIBSSH2_DEBUG
if(conn->passwd) {
infof(data, "Password: %s", conn->passwd);
}