From 3f041a3852a9694fec6a480cb32cf45582ecab21 Mon Sep 17 00:00:00 2001 From: Daniel Stenberg Date: Mon, 23 Dec 2024 00:11:31 +0100 Subject: [PATCH] vquic: fix 4th function call argument is an uninitialized value As recvmmsg_packets() could fail early and goto out before 'pkts' were assigned. Caught by clang-tidy Closes #15808 --- lib/vquic/vquic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/vquic/vquic.c b/lib/vquic/vquic.c index 20ff6a640b..41a2cc9757 100644 --- a/lib/vquic/vquic.c +++ b/lib/vquic/vquic.c @@ -363,7 +363,7 @@ static CURLcode recvmmsg_packets(struct Curl_cfilter *cf, struct mmsghdr mmsg[MMSG_NUM]; uint8_t msg_ctrl[MMSG_NUM * CMSG_SPACE(sizeof(int))]; struct sockaddr_storage remote_addr[MMSG_NUM]; - size_t total_nread = 0, pkts; + size_t total_nread = 0, pkts = 0; int mcount, i, n; char errstr[STRERROR_LEN]; CURLcode result = CURLE_OK; @@ -380,7 +380,6 @@ static CURLcode recvmmsg_packets(struct Curl_cfilter *cf, goto out; bufs = (uint8_t (*)[64*1024])sockbuf; - pkts = 0; total_nread = 0; while(pkts < max_pkts) { n = (int)CURLMIN(MMSG_NUM, max_pkts);