From 30ba26d9c3f6c98024e47934279a8b5f3d5591ca Mon Sep 17 00:00:00 2001 From: Jay Satiro Date: Wed, 3 May 2023 14:48:04 -0400 Subject: [PATCH] tool_cb_hdr: Fix 'Location:' formatting for early VTE terminals - Disable hyperlink formatting for the 'Location:' header value in VTE 0.48.1 and earlier, since it is buggy in some of those versions. Prior to this change those terminals may show the location header value as gibberish or show it twice. Ref: https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda#backward-compatibility Fixes https://github.com/curl/curl/issues/10428 Closes https://github.com/curl/curl/pull/11071 --- src/tool_cb_hdr.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/tool_cb_hdr.c b/src/tool_cb_hdr.c index 04817af6cc..ed22ef460a 100644 --- a/src/tool_cb_hdr.c +++ b/src/tool_cb_hdr.c @@ -344,6 +344,15 @@ void write_linked_location(CURL *curl, const char *location, size_t loclen, char *copyloc = NULL, *locurl = NULL, *scheme = NULL, *finalurl = NULL; const char *loc = location; size_t llen = loclen; + char *vver = getenv("VTE_VERSION"); + + if(vver) { + long vvn = strtol(vver, NULL, 10); + /* Skip formatting for old versions of VTE <= 0.48.1 (Mar 2017) since some + of those versions have formatting bugs. (#10428) */ + if(0 < vvn && vvn <= 4801) + goto locout; + } /* Strip leading whitespace of the redirect URL */ while(llen && *loc == ' ') {