luo980/curl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pop3: revert connection ssl check

Browse Source 
As reported in #16166, the STLS hangs with the check for SSL connection
filters, but is working with the old protocol handler way. Revert the
change, although it is unclear why it was no good here.

Fixes #16166
Reported-by: ralfjunker on github
Closes #16172
This commit is contained in:
Stefan Eissing 2025-02-04 21:53:55 +01:00 committed by Daniel Stenberg
parent 1b4e635134
commit 2578dae41b
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/pop3.c
View File

@ -1112,7 +1112,10 @@ static CURLcode pop3_multi_statemach(struct Curl_easy *data, bool *done)
struct connectdata *conn = data->conn;
struct pop3_conn *pop3c = &conn->proto.pop3c;
if(Curl_conn_is_ssl(conn, FIRSTSOCKET) && !pop3c->ssldone) {
/* Issue #16166, STLS seems to stall and time out. Revert to previous
* check, but it remains to find out why this is wrong. */
/* if(Curl_conn_is_ssl(conn, FIRSTSOCKET) && !pop3c->ssldone) { */
if((conn->handler->flags & PROTOPT_SSL) && !pop3c->ssldone) {
bool ssldone = FALSE;
result = Curl_conn_connect(data, FIRSTSOCKET, FALSE, &ssldone);
pop3c->ssldone = ssldone;