luo980/curl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

http tests: in CI skip test_02_23* for quiche

Browse Source 
For unknown reasons, these tests fail in CI often, but run fine locally.
Skip them in CI to avoid unrelated PRs to have failures.

Closes #13638
This commit is contained in:
Stefan Eissing 2024-05-14 12:32:09 +02:00 committed by Daniel Stenberg
parent d84a95de11
commit 22d8ce1970
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/http/test_02_download.py
View File

@ -360,6 +360,8 @@ class TestDownload:
def test_02_23a_lib_abort_paused(self, env: Env, httpd, nghttpx, proto, repeat): def test_02_23a_lib_abort_paused(self, env: Env, httpd, nghttpx, proto, repeat):
if proto == 'h3' and env.curl_uses_ossl_quic(): if proto == 'h3' and env.curl_uses_ossl_quic():
pytest.skip('OpenSSL QUIC fails here') pytest.skip('OpenSSL QUIC fails here')
if proto == 'h3' and env.ci_run and env.curl_uses_lib('quiche'):
pytest.skip("fails in CI, but works locally for unknown reasons")
if proto in ['h2', 'h3']: if proto in ['h2', 'h3']:
count = 200 count = 200
max_parallel = 100 max_parallel = 100
@ -387,6 +389,8 @@ class TestDownload:
def test_02_23b_lib_abort_offset(self, env: Env, httpd, nghttpx, proto, repeat): def test_02_23b_lib_abort_offset(self, env: Env, httpd, nghttpx, proto, repeat):
if proto == 'h3' and env.curl_uses_ossl_quic(): if proto == 'h3' and env.curl_uses_ossl_quic():
pytest.skip('OpenSSL QUIC fails here') pytest.skip('OpenSSL QUIC fails here')
if proto == 'h3' and env.ci_run and env.curl_uses_lib('quiche'):
pytest.skip("fails in CI, but works locally for unknown reasons")
if proto in ['h2', 'h3']: if proto in ['h2', 'h3']:
count = 200 count = 200
max_parallel = 100 max_parallel = 100
@ -414,6 +418,8 @@ class TestDownload:
def test_02_23c_lib_fail_offset(self, env: Env, httpd, nghttpx, proto, repeat): def test_02_23c_lib_fail_offset(self, env: Env, httpd, nghttpx, proto, repeat):
if proto == 'h3' and env.curl_uses_ossl_quic(): if proto == 'h3' and env.curl_uses_ossl_quic():
pytest.skip('OpenSSL QUIC fails here') pytest.skip('OpenSSL QUIC fails here')
if proto == 'h3' and env.ci_run and env.curl_uses_lib('quiche'):
pytest.skip("fails in CI, but works locally for unknown reasons")
if proto in ['h2', 'h3']: if proto in ['h2', 'h3']:
count = 200 count = 200
max_parallel = 100 max_parallel = 100

7
tests/http/testenv/curl.py
View File

@ -541,11 +541,11 @@ class CurlClient:
started_at = datetime.now() started_at = datetime.now()
exception = None exception = None
profile = None profile = None
started_at = datetime.now()
try: try:
with open(self._stdoutfile, 'w') as cout: with open(self._stdoutfile, 'w') as cout:
with open(self._stderrfile, 'w') as cerr: with open(self._stderrfile, 'w') as cerr:
if with_profile: if with_profile:
started_at = datetime.now()
end_at = started_at + timedelta(seconds=self._timeout) \ end_at = started_at + timedelta(seconds=self._timeout) \
if self._timeout else None if self._timeout else None
log.info(f'starting: {args}') log.info(f'starting: {args}')
@ -575,7 +575,10 @@ class CurlClient:
timeout=self._timeout) timeout=self._timeout)
exitcode = p.returncode exitcode = p.returncode
except subprocess.TimeoutExpired: except subprocess.TimeoutExpired:
log.warning(f'Timeout after {self._timeout}s: {args}') now = datetime.now()
duration = now - started_at
log.warning(f'Timeout at {now} after {duration.total_seconds()}s '
f'(configured {self._timeout}s): {args}')
exitcode = -1 exitcode = -1
exception = 'TimeoutExpired' exception = 'TimeoutExpired'
coutput = open(self._stdoutfile).readlines() coutput = open(self._stdoutfile).readlines()