From 2154f7c5f3fc28ff74031b5d8f6ece12179118eb Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Wed, 7 Aug 2024 04:27:49 +0200 Subject: [PATCH] krb5: fix `-Wcast-align` ``` lib/krb5.c:343:39: warning: cast from 'void **' to 'unsigned char **' increases required alignment from 2 to 8 [-Wcast-align] (unsigned char **)&_gssresp.value, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` Seen on macOS Intel with Apple clang and brew heimdal 7.8.0_1. Closes #14433 --- lib/krb5.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/krb5.c b/lib/krb5.c index 7bc2f00ec8..f3649cd1ab 100644 --- a/lib/krb5.c +++ b/lib/krb5.c @@ -336,17 +336,20 @@ krb5_auth(void *app_data, struct Curl_easy *data, struct connectdata *conn) } _gssresp.value = NULL; /* make sure it is initialized */ + _gssresp.length = 0; p += 4; /* over '789 ' */ p = strstr(p, "ADAT="); if(p) { - result = Curl_base64_decode(p + 5, - (unsigned char **)&_gssresp.value, - &_gssresp.length); + unsigned char *outptr; + size_t outlen; + result = Curl_base64_decode(p + 5, &outptr, &outlen); if(result) { failf(data, "base64-decoding: %s", curl_easy_strerror(result)); ret = AUTH_CONTINUE; break; } + _gssresp.value = outptr; + _gssresp.length = outlen; } gssresp = &_gssresp;