From 11d27cf341972f3e901ecc12dbfe543cbcf569ef Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Thu, 4 Apr 2024 21:22:37 +0000 Subject: [PATCH] cmake: enable `-pedantic-errors` for clang when `CURL_WERROR=ON` clang doesn't have the issues of GCC and old CMake versions. Note: This introduces asymmetry with autotools, which only enables this for GCC. Reviewed-by: Daniel Stenberg Closes #13286 --- CMake/PickyWarnings.cmake | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/CMake/PickyWarnings.cmake b/CMake/PickyWarnings.cmake index 3510d77a73..d1183fe392 100644 --- a/CMake/PickyWarnings.cmake +++ b/CMake/PickyWarnings.cmake @@ -26,9 +26,10 @@ include(CheckCCompilerFlag) unset(WPICKY) if(CURL_WERROR AND - CMAKE_COMPILER_IS_GNUCC AND - NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 5.0 AND - NOT CMAKE_VERSION VERSION_LESS 3.23.0) # check_symbol_exists() incompatible with GCC -pedantic-errors in earlier CMake versions + ((CMAKE_COMPILER_IS_GNUCC AND + NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 5.0 AND + NOT CMAKE_VERSION VERSION_LESS 3.23.0) OR # check_symbol_exists() incompatible with GCC -pedantic-errors in earlier CMake versions + CMAKE_C_COMPILER_ID MATCHES "Clang")) set(WPICKY "${WPICKY} -pedantic-errors") endif()