luo980/curl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cookie: minor parser simplification

Browse Source 
- parse whitespace before the value is handled
- remove superflous checks from some ISBLANK() loops

Closes #16362
This commit is contained in:
Daniel Stenberg 2025-02-17 11:15:32 +01:00
parent 676de7f580
commit 0064708f3f
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
lib/cookie.c
View File

@ -518,7 +518,7 @@ parse_cookie_header(struct Curl_easy *data,
size_t vlen;
size_t nlen;
while(*ptr && ISBLANK(*ptr))
while(ISBLANK(*ptr))
ptr++;
/* we have a <name>=<value> pair or a stand-alone word here */
@ -536,7 +536,12 @@ parse_cookie_header(struct Curl_easy *data,
nlen--;
if(*ptr == '=') {
vlen = strcspn(++ptr, ";\r\n");
ptr++;
/* Skip spaces and tabs before the value */
while(ISBLANK(*ptr))
ptr++;
vlen = strcspn(ptr, ";\r\n");
valuep = ptr;
sep = TRUE;
ptr = &valuep[vlen];
@ -545,12 +550,6 @@ parse_cookie_header(struct Curl_easy *data,
while(vlen && ISBLANK(valuep[vlen-1]))
vlen--;
/* Skip leading whitespace from the value */
while(vlen && ISBLANK(*valuep)) {
valuep++;
vlen--;
}
/* Reject cookies with a TAB inside the value */
if(memchr(valuep, '\t', vlen)) {
infof(data, "cookie contains TAB, dropping");
@ -769,7 +768,7 @@ parse_cookie_header(struct Curl_easy *data,
/* this is an "illegal" <what>=<this> pair */
}
while(*ptr && ISBLANK(*ptr))
while(ISBLANK(*ptr))
ptr++;
if(*ptr == ';')
ptr++;
@ -1283,7 +1282,7 @@ struct CookieInfo *Curl_cookie_init(struct Curl_easy *data,
/* This is a cookie line, get it! */
lineptr += 11;
headerline = TRUE;
while(*lineptr && ISBLANK(*lineptr))
while(ISBLANK(*lineptr))
lineptr++;
}