luo980/curl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tool_getparam: DNS options that need c-ares now fail without it

Browse Source 
Just silently accepting the options and then not having any effect is
not good.

Ref: #8283
Closes #8285
This commit is contained in:
Daniel Stenberg 2022-01-16 22:41:16 +01:00
parent f974bee623
commit 0041fe7ef5
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/tool_getparam.c
View File

@ -654,10 +654,14 @@ ParameterError getparameter(const char *flag, /* f or -long-flag */
case '*': /* options without a short option */
switch(subletter) {
case '4': /* --dns-ipv4-addr */
if(!curlinfo->ares_num) /* c-ares is needed for this */
return PARAM_LIBCURL_DOESNT_SUPPORT;
/* addr in dot notation */
GetStr(&config->dns_ipv4_addr, nextarg);
break;
case '6': /* --dns-ipv6-addr */
if(!curlinfo->ares_num) /* c-ares is needed for this */
return PARAM_LIBCURL_DOESNT_SUPPORT;
/* addr in dot notation */
GetStr(&config->dns_ipv6_addr, nextarg);
break;
@ -685,6 +689,8 @@ ParameterError getparameter(const char *flag, /* f or -long-flag */
GetStr(&config->cipher_list, nextarg);
break;
case 'D': /* --dns-interface */
if(!curlinfo->ares_num) /* c-ares is needed for this */
return PARAM_LIBCURL_DOESNT_SUPPORT;
/* interface name */
GetStr(&config->dns_interface, nextarg);
break;
@ -698,6 +704,8 @@ ParameterError getparameter(const char *flag, /* f or -long-flag */
config->disable_epsv = (!toggle)?TRUE:FALSE;
break;
case 'F': /* --dns-servers */
if(!curlinfo->ares_num) /* c-ares is needed for this */
return PARAM_LIBCURL_DOESNT_SUPPORT;
/* IP addrs of DNS servers */
GetStr(&config->dns_servers, nextarg);
break;