Thank you for the very useful library! Few improvements: - Better header hygiene - Isolate `windows.h` to `.cpp` whenever possible - Use `WIN32_LEAN_AND_MEAN` - Remove unused headers Tested on Windows with ``` cmake .. -DCMAKE_BUILD_TYPE=Debug -GNinja -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_CXX_FLAGS="-ftime-trace -Wall -Wextra -Wpedantic -Wno-ignored-attributes" -DCMAKE_COLOR_DIAGNOSTICS=1 -DCPPTRACE_BUILD_TESTING=1 -DCPPTRACE_BUILD_BENCHMARKING=0 ``` There's a lot more that can be improved if you are interested. --------- Co-authored-by: Jeremy Rifkin <51220084+jeremy-rifkin@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| add_subdirectory-integration | ||
| expected | ||
| fetchcontent-integration | ||
| findpackage-integration | ||
| speedtest | ||
| unit | ||
| BUILD.bazel | ||
| CMakeLists.txt | ||
| ctrace_demo.c | ||
| demo.cpp | ||
| integration.cpp | ||
| signal_demo.cpp | ||
| signal_tracer.cpp | ||