Thank you for the very useful library! Few improvements: - Better header hygiene - Isolate `windows.h` to `.cpp` whenever possible - Use `WIN32_LEAN_AND_MEAN` - Remove unused headers Tested on Windows with ``` cmake .. -DCMAKE_BUILD_TYPE=Debug -GNinja -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_CXX_FLAGS="-ftime-trace -Wall -Wextra -Wpedantic -Wno-ignored-attributes" -DCMAKE_COLOR_DIAGNOSTICS=1 -DCPPTRACE_BUILD_TESTING=1 -DCPPTRACE_BUILD_BENCHMARKING=0 ``` There's a lot more that can be improved if you are interested. --------- Co-authored-by: Jeremy Rifkin <51220084+jeremy-rifkin@users.noreply.github.com>
24 lines
568 B
C++
24 lines
568 B
C++
#ifdef CPPTRACE_GET_SYMBOLS_WITH_NOTHING
|
|
|
|
#include <cpptrace/cpptrace.hpp>
|
|
#include "symbols/symbols.hpp"
|
|
#include "utils/common.hpp"
|
|
|
|
#include <vector>
|
|
|
|
namespace cpptrace {
|
|
namespace detail {
|
|
namespace nothing {
|
|
std::vector<stacktrace_frame> resolve_frames(const std::vector<frame_ptr>& frames) {
|
|
return std::vector<stacktrace_frame>(frames.size(), null_frame);
|
|
}
|
|
|
|
std::vector<stacktrace_frame> resolve_frames(const std::vector<object_frame>& frames) {
|
|
return std::vector<stacktrace_frame>(frames.size(), null_frame);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
#endif
|