Thank you for the very useful library! Few improvements: - Better header hygiene - Isolate `windows.h` to `.cpp` whenever possible - Use `WIN32_LEAN_AND_MEAN` - Remove unused headers Tested on Windows with ``` cmake .. -DCMAKE_BUILD_TYPE=Debug -GNinja -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_CXX_FLAGS="-ftime-trace -Wall -Wextra -Wpedantic -Wno-ignored-attributes" -DCMAKE_COLOR_DIAGNOSTICS=1 -DCPPTRACE_BUILD_TESTING=1 -DCPPTRACE_BUILD_BENCHMARKING=0 ``` There's a lot more that can be improved if you are interested. --------- Co-authored-by: Jeremy Rifkin <51220084+jeremy-rifkin@users.noreply.github.com>
66 lines
2.7 KiB
C++
66 lines
2.7 KiB
C++
#include <string_view>
|
|
#include <string>
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <gtest/gtest-matchers.h>
|
|
#include <gmock/gmock.h>
|
|
#include <gmock/gmock-matchers.h>
|
|
|
|
#include <cpptrace/cpptrace.hpp>
|
|
|
|
using namespace std::literals;
|
|
|
|
|
|
// NOTE: returning something and then return stacktrace_traced_object_3(line_numbers) * 2; later helps prevent the call from
|
|
// being optimized to a jmp
|
|
CPPTRACE_FORCE_NO_INLINE int stacktrace_traced_object_3(std::vector<int>& line_numbers) {
|
|
line_numbers.insert(line_numbers.begin(), __LINE__ + 1);
|
|
throw cpptrace::runtime_error("foobar");
|
|
}
|
|
|
|
CPPTRACE_FORCE_NO_INLINE int stacktrace_traced_object_2(std::vector<int>& line_numbers) {
|
|
line_numbers.insert(line_numbers.begin(), __LINE__ + 1);
|
|
return stacktrace_traced_object_3(line_numbers) * 2;
|
|
}
|
|
|
|
CPPTRACE_FORCE_NO_INLINE int stacktrace_traced_object_1(std::vector<int>& line_numbers) {
|
|
line_numbers.insert(line_numbers.begin(), __LINE__ + 1);
|
|
return stacktrace_traced_object_2(line_numbers) * 2;
|
|
}
|
|
|
|
TEST(TracedException, Basic) {
|
|
std::vector<int> line_numbers;
|
|
try {
|
|
line_numbers.insert(line_numbers.begin(), __LINE__ + 1);
|
|
stacktrace_traced_object_1(line_numbers);
|
|
} catch(cpptrace::exception& e) {
|
|
EXPECT_EQ(e.message(), "foobar"sv);
|
|
const auto& trace = e.trace();
|
|
ASSERT_GE(trace.frames.size(), 4);
|
|
size_t i = 0;
|
|
ASSERT_LT(i, trace.frames.size());
|
|
ASSERT_LT(i, line_numbers.size());
|
|
EXPECT_THAT(trace.frames[i].filename, testing::EndsWith("traced_exception.cpp"));
|
|
EXPECT_EQ(trace.frames[i].line.value(), line_numbers[i]);
|
|
EXPECT_THAT(trace.frames[i].symbol, testing::HasSubstr("stacktrace_traced_object_3"));
|
|
i++;
|
|
ASSERT_LT(i, trace.frames.size());
|
|
ASSERT_LT(i, line_numbers.size());
|
|
EXPECT_THAT(trace.frames[i].filename, testing::EndsWith("traced_exception.cpp"));
|
|
EXPECT_EQ(trace.frames[i].line.value(), line_numbers[i]);
|
|
EXPECT_THAT(trace.frames[i].symbol, testing::HasSubstr("stacktrace_traced_object_2"));
|
|
i++;
|
|
ASSERT_LT(i, trace.frames.size());
|
|
ASSERT_LT(i, line_numbers.size());
|
|
EXPECT_THAT(trace.frames[i].filename, testing::EndsWith("traced_exception.cpp"));
|
|
EXPECT_EQ(trace.frames[i].line.value(), line_numbers[i]);
|
|
EXPECT_THAT(trace.frames[i].symbol, testing::HasSubstr("stacktrace_traced_object_1"));
|
|
i++;
|
|
ASSERT_LT(i, trace.frames.size());
|
|
ASSERT_LT(i, line_numbers.size());
|
|
EXPECT_THAT(trace.frames[i].filename, testing::EndsWith("traced_exception.cpp"));
|
|
EXPECT_EQ(trace.frames[i].line.value(), line_numbers[i]);
|
|
EXPECT_THAT(trace.frames[i].symbol, testing::HasSubstr("TracedException_Basic_Test::TestBody"));
|
|
}
|
|
}
|