luo980/cpptrace
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix incorrect handling of lazy_trace_holder's union, I can't believe I wrote such egregious code

Browse Source
This commit is contained in:
Jeremy 2024-05-23 22:33:56 -05:00
parent 6307700710
commit f8d28a6469
No known key found for this signature in database
GPG Key ID: 19AA8270105E8EB4
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/cpptrace.cpp
View File

@ -518,13 +518,12 @@ namespace cpptrace {
// access
stacktrace& lazy_trace_holder::get_resolved_trace() {
if(!resolved) {
stacktrace new_trace;
raw_trace old_trace = std::move(trace);
*this = lazy_trace_holder(stacktrace{});
try {
if(resolved_trace.empty() && !trace.empty()) {
resolved_trace = trace.resolve();
trace.clear();
if(!old_trace.empty()) {
resolved_trace = old_trace.resolve();
}
new_trace = trace.resolve();
} catch(const std::exception& e) {
if(!detail::should_absorb_trace_exceptions()) {
// TODO: Append to message somehow?
@ -535,9 +534,6 @@ namespace cpptrace {
);
}
}
trace.~raw_trace();
new (&resolved_trace) stacktrace(std::move(new_trace));
resolved = true;
}
return resolved_trace;
}