luo980/cpptrace
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: actually use ccache binary returned by find_program

Browse Source 
The original code assumed that if `find_program` found `ccache`,
then `ccache` must be in the `PATH`. However, `find_program`
searches in a lot of different places. This can lead to situations
where `ccache` is found, but the compile will fail because it's
not in the path.

This change also uses `CMAKE_XXX_COMPILER_LAUNCHER` instead of
`RULE_LAUNCH_COMPILE`, as the latter is for internal use only
per the CMake docs.
This commit is contained in:
Marcus Holland-Moritz 2024-10-18 13:01:32 +02:00
parent 7a0c6ec78d
commit 969d7cedaa
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
CMakeLists.txt
View File

@ -24,9 +24,10 @@ include(CheckCXXSourceCompiles)
include(CheckCXXCompilerFlag) include(CheckCXXCompilerFlag)
if(PROJECT_IS_TOP_LEVEL) if(PROJECT_IS_TOP_LEVEL)
find_program(CCACHE_FOUND ccache) find_program(CCACHE_PROGRAM ccache)
if(CCACHE_FOUND) if(CCACHE_PROGRAM)
set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ccache) set(CMAKE_C_COMPILER_LAUNCHER ${CCACHE_PROGRAM})
set(CMAKE_CXX_COMPILER_LAUNCHER ${CCACHE_PROGRAM})
endif() endif()
endif() endif()