luo980/cpptrace
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use _exit() over exit()

Browse Source
This commit is contained in:
Jeremy 2023-07-09 21:50:39 -04:00
parent 6d9d2a9747
commit 57f5cc529c
No known key found for this signature in database
GPG Key ID: 19AA8270105E8EB4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/symbols/symbols_with_addr2line.cpp
View File

@ -72,7 +72,7 @@ namespace cpptrace {
close(STDERR_FILENO); // TODO: Might be worth conditionally enabling or piping close(STDERR_FILENO); // TODO: Might be worth conditionally enabling or piping
// TODO: Prevent against path injection? // TODO: Prevent against path injection?
execlp("addr2line", "addr2line", "-e", executable.c_str(), "-f", "-C", "-p", nullptr); execlp("addr2line", "addr2line", "-e", executable.c_str(), "-f", "-C", "-p", nullptr);
exit(1); // TODO: Diagnostic? _exit(1); // TODO: Diagnostic?
} }
internal_verify(write(input_pipe.write_end, addresses.data(), addresses.size()) != -1); internal_verify(write(input_pipe.write_end, addresses.data(), addresses.size()) != -1);
close(input_pipe.read_end); close(input_pipe.read_end);