luo980/cpptrace
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve dbghelp symbolization thread safety

Browse Source
This commit is contained in:
Jeremy 2023-09-19 11:05:04 -04:00
parent 7195ea43a2
commit 137dc78710
No known key found for this signature in database
GPG Key ID: 19AA8270105E8EB4
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/symbols/symbols_with_dbghelp.cpp
View File

@ -321,11 +321,11 @@ namespace dbghelp {
return true;
}
std::mutex dbghelp_lock;
std::recursive_mutex dbghelp_lock;
// TODO: Handle backtrace_pcinfo calling the callback multiple times on inlined functions
stacktrace_frame resolve_frame(HANDLE proc, uintptr_t addr) {
const std::lock_guard<std::mutex> lock(dbghelp_lock); // all dbghelp functions are not thread safe
const std::lock_guard<std::recursive_mutex> lock(dbghelp_lock); // all dbghelp functions are not thread safe
alignas(SYMBOL_INFO) char buffer[sizeof(SYMBOL_INFO) + MAX_SYM_NAME * sizeof(TCHAR)];
SYMBOL_INFO* symbol = (SYMBOL_INFO*)buffer;
symbol->SizeOfStruct = sizeof(SYMBOL_INFO);
@ -402,6 +402,7 @@ namespace dbghelp {
}
std::vector<stacktrace_frame> resolve_frames(const std::vector<uintptr_t>& frames) {
const std::lock_guard<std::recursive_mutex> lock(dbghelp_lock); // all dbghelp functions are not thread safe
std::vector<stacktrace_frame> trace;
trace.reserve(frames.size());