luo980/cpptrace
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

For the libbacktrace back-end don't treat missing debug info in ELFs as a critical error; fixes #114

Browse Source
This commit is contained in:
Jeremy 2024-04-28 19:51:52 -05:00
parent c871c2a43c
commit 0527cea39f
No known key found for this signature in database
GPG Key ID: 19AA8270105E8EB4
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/symbols/symbols_with_libbacktrace.cpp
View File

@ -38,6 +38,12 @@ namespace libbacktrace {
} }
void error_callback(void*, const char* msg, int errnum) { void error_callback(void*, const char* msg, int errnum) {
if(msg == std::string("no debug info in ELF executable")) {
// https://github.com/jeremy-rifkin/cpptrace/issues/114
// https://github.com/ianlancetaylor/libbacktrace/blob/ae1e707dbacd4a5cc82fcf2d3816f410e9c5fec4/elf.c#L592
// not a critical error, just return
return;
}
throw internal_error("Libbacktrace error: {}, code {}", msg, errnum); throw internal_error("Libbacktrace error: {}, code {}", msg, errnum);
} }
@ -57,8 +63,8 @@ namespace libbacktrace {
// TODO: Handle backtrace_pcinfo calling the callback multiple times on inlined functions // TODO: Handle backtrace_pcinfo calling the callback multiple times on inlined functions
stacktrace_frame resolve_frame(const frame_ptr addr) { stacktrace_frame resolve_frame(const frame_ptr addr) {
try { try {
stacktrace_frame frame; stacktrace_frame frame = null_frame;
frame.column = nullable<std::uint32_t>::null(); frame.raw_address = addr;
backtrace_pcinfo( backtrace_pcinfo(
get_backtrace_state(), get_backtrace_state(),
addr, addr,