luo980/cpp-httplib
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove select() and use poll()

Browse Source
This commit is contained in:
Florian Albrechtskirchinger 2025-02-20 19:38:37 +01:00
parent e541dfc6b7
commit 644b5910a6
No known key found for this signature in database
GPG Key ID: 9C4E2AE92D3A9595
3 changed files with 4 additions and 83 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Dockerfile
View File

@ -2,7 +2,7 @@ FROM yhirose4dockerhub/ubuntu-builder AS builder
WORKDIR /build WORKDIR /build
COPY httplib.h . COPY httplib.h .
COPY docker/main.cc . COPY docker/main.cc .
RUN g++ -std=c++23 -static -o server -O2 -I. -DCPPHTTPLIB_USE_POLL main.cc && strip server RUN g++ -std=c++23 -static -o server -O2 -I. main.cc && strip server
FROM scratch FROM scratch
COPY --from=builder /build/server /server COPY --from=builder /build/server /server

5
README.md
View File

@ -872,11 +872,6 @@ res->body; // Compressed data
``` ```
Use `poll` instead of `select`
------------------------------
`select` system call is used as default since it's more widely supported. If you want to let cpp-httplib use `poll` instead, you can do so with `CPPHTTPLIB_USE_POLL`.
Unix Domain Socket Support Unix Domain Socket Support
-------------------------- --------------------------

80
httplib.h
View File

@ -194,9 +194,7 @@ using ssize_t = long;
using socket_t = SOCKET; using socket_t = SOCKET;
using socklen_t = int; using socklen_t = int;
#ifdef CPPHTTPLIB_USE_POLL
#define poll(fds, nfds, timeout) WSAPoll(fds, nfds, timeout) #define poll(fds, nfds, timeout) WSAPoll(fds, nfds, timeout)
#endif
#else // not _WIN32 #else // not _WIN32
@ -216,16 +214,11 @@ using socklen_t = int;
#ifdef __linux__ #ifdef __linux__
#include <resolv.h> #include <resolv.h>
#endif #endif
#include <netinet/tcp.h>
#ifdef CPPHTTPLIB_USE_POLL
#include <poll.h>
#endif
#include <csignal> #include <csignal>
#include <netinet/tcp.h>
#include <poll.h>
#include <pthread.h> #include <pthread.h>
#include <sys/mman.h> #include <sys/mman.h>
#ifndef __VMS
#include <sys/select.h>
#endif
#include <sys/socket.h> #include <sys/socket.h>
#include <sys/un.h> #include <sys/un.h>
#include <unistd.h> #include <unistd.h>
@ -3259,7 +3252,6 @@ inline ssize_t send_socket(socket_t sock, const void *ptr, size_t size,
template <bool Read> template <bool Read>
inline ssize_t select_impl(socket_t sock, time_t sec, time_t usec) { inline ssize_t select_impl(socket_t sock, time_t sec, time_t usec) {
#ifdef CPPHTTPLIB_USE_POLL
struct pollfd pfd; struct pollfd pfd;
pfd.fd = sock; pfd.fd = sock;
pfd.events = (Read ? POLLIN : POLLOUT); pfd.events = (Read ? POLLIN : POLLOUT);
@ -3267,25 +3259,6 @@ inline ssize_t select_impl(socket_t sock, time_t sec, time_t usec) {
auto timeout = static_cast<int>(sec * 1000 + usec / 1000); auto timeout = static_cast<int>(sec * 1000 + usec / 1000);
return handle_EINTR([&]() { return poll(&pfd, 1, timeout); }); return handle_EINTR([&]() { return poll(&pfd, 1, timeout); });
#else
#ifndef _WIN32
if (sock >= FD_SETSIZE) { return -1; }
#endif
fd_set fds, *rfds, *wfds;
FD_ZERO(&fds);
FD_SET(sock, &fds);
rfds = (Read ? &fds : nullptr);
wfds = (Read ? nullptr : &fds);
timeval tv;
tv.tv_sec = static_cast<long>(sec);
tv.tv_usec = static_cast<decltype(tv.tv_usec)>(usec);
return handle_EINTR([&]() {
return select(static_cast<int>(sock + 1), rfds, wfds, nullptr, &tv);
});
#endif
} }
inline ssize_t select_read(socket_t sock, time_t sec, time_t usec) { inline ssize_t select_read(socket_t sock, time_t sec, time_t usec) {
@ -3298,7 +3271,6 @@ inline ssize_t select_write(socket_t sock, time_t sec, time_t usec) {
inline Error wait_until_socket_is_ready(socket_t sock, time_t sec, inline Error wait_until_socket_is_ready(socket_t sock, time_t sec,
time_t usec) { time_t usec) {
#ifdef CPPHTTPLIB_USE_POLL
struct pollfd pfd_read; struct pollfd pfd_read;
pfd_read.fd = sock; pfd_read.fd = sock;
pfd_read.events = POLLIN | POLLOUT; pfd_read.events = POLLIN | POLLOUT;
@ -3319,38 +3291,6 @@ inline Error wait_until_socket_is_ready(socket_t sock, time_t sec,
} }
return Error::Connection; return Error::Connection;
#else
#ifndef _WIN32
if (sock >= FD_SETSIZE) { return Error::Connection; }
#endif
fd_set fdsr;
FD_ZERO(&fdsr);
FD_SET(sock, &fdsr);
auto fdsw = fdsr;
auto fdse = fdsr;
timeval tv;
tv.tv_sec = static_cast<long>(sec);
tv.tv_usec = static_cast<decltype(tv.tv_usec)>(usec);
auto ret = handle_EINTR([&]() {
return select(static_cast<int>(sock + 1), &fdsr, &fdsw, &fdse, &tv);
});
if (ret == 0) { return Error::ConnectionTimeout; }
if (ret > 0 && (FD_ISSET(sock, &fdsr) || FD_ISSET(sock, &fdsw))) {
auto error = 0;
socklen_t len = sizeof(error);
auto res = getsockopt(sock, SOL_SOCKET, SO_ERROR,
reinterpret_cast<char *>(&error), &len);
auto successful = res >= 0 && !error;
return successful ? Error::Success : Error::Connection;
}
return Error::Connection;
#endif
} }
inline bool is_socket_alive(socket_t sock) { inline bool is_socket_alive(socket_t sock) {
@ -7196,20 +7136,6 @@ Server::process_request(Stream &strm, const std::string &remote_addr,
res.version = "HTTP/1.1"; res.version = "HTTP/1.1";
res.headers = default_headers_; res.headers = default_headers_;
#ifdef _WIN32
// TODO: Increase FD_SETSIZE statically (libzmq), dynamically (MySQL).
#else
#ifndef CPPHTTPLIB_USE_POLL
// Socket file descriptor exceeded FD_SETSIZE...
if (strm.socket() >= FD_SETSIZE) {
Headers dummy;
detail::read_headers(strm, dummy);
res.status = StatusCode::InternalServerError_500;
return write_response(strm, close_connection, req, res);
}
#endif
#endif
// Request line and headers // Request line and headers
if (!parse_request_line(line_reader.ptr(), req) || if (!parse_request_line(line_reader.ptr(), req) ||
!detail::read_headers(strm, req.headers)) { !detail::read_headers(strm, req.headers)) {
@ -10440,7 +10366,7 @@ inline SSL_CTX *Client::ssl_context() const {
} // namespace httplib } // namespace httplib
#if defined(_WIN32) && defined(CPPHTTPLIB_USE_POLL) #ifdef _WIN32
#undef poll #undef poll
#endif #endif